From: Junio C Hamano <gitster@pobox.com>
To: Derrick Stolee <stolee@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: sg/commit-graph-cleanups (was Re: What's cooking in git.git (Jul 2020, #01; Mon, 6))
Date: Tue, 07 Jul 2020 08:12:16 -0700 [thread overview]
Message-ID: <xmqqzh8b5pgv.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <90cf9ac2-1ab0-1c9b-706b-6c5176ab47dd@gmail.com> (Derrick Stolee's message of "Tue, 7 Jul 2020 09:29:29 -0400")
Derrick Stolee <stolee@gmail.com> writes:
> On 7/7/2020 1:57 AM, Junio C Hamano wrote:
>> * ds/commit-graph-bloom-updates (2020-07-01) 10 commits
>> (merged to 'next' on 2020-07-06 at 177e6b362e)
>> + commit-graph: check all leading directories in changed path Bloom filters
>> + revision: empty pathspecs should not use Bloom filters
>> + revision.c: fix whitespace
>> + commit-graph: check chunk sizes after writing
>> + commit-graph: simplify chunk writes into loop
>> + commit-graph: unify the signatures of all write_graph_chunk_*() functions
>> + commit-graph: persist existence of changed-paths
>> + bloom: fix logic in get_bloom_filter()
>> + commit-graph: change test to die on parse, not load
>> + commit-graph: place bloom_settings in context
>> (this branch uses sg/commit-graph-cleanups.)
>>
>> Updates to the changed-paths bloom filter.
>>
>> Will merge to 'master'.
>>
>> * sg/commit-graph-cleanups (2020-06-08) 10 commits
>> + commit-graph: simplify write_commit_graph_file() #2
>> + commit-graph: simplify write_commit_graph_file() #1
>> + commit-graph: simplify parse_commit_graph() #2
>> + commit-graph: simplify parse_commit_graph() #1
>> + commit-graph: clean up #includes
>> + diff.h: drop diff_tree_oid() & friends' return value
>> + commit-slab: add a function to deep free entries on the slab
>> + commit-graph-format.txt: all multi-byte numbers are in network byte order
>> + commit-graph: fix parsing the Chunk Lookup table
>> + tree-walk.c: don't match submodule entries for 'submod/anything'
>> (this branch is used by ds/commit-graph-bloom-updates.)
>>
>> The changed-path Bloom filter is improved using ideas from an
>> independent implementation.
>>
>> Under review.
>> cf. <20200627155610.GN2898@szeder.dev>
>> cf. <20200627163335.GO2898@szeder.dev>
>> cf. <20200627155348.GM2898@szeder.dev>
>
> I see these are both in 'next' (thanks!).
>
> Perhaps the "Under review" status for sg/commit-graph-cleanups
> should be modified to match ds/commit-graph-bloom-updates?
Oops, I am not sure what happened here. There I thought were issues
pointed out at least on the latter series but was I hallucinating?
For now, as -rc0 is so close, I'm tempted to mark both of them to be
cooked in 'next' during the rc period.
Thanks.
next prev parent reply other threads:[~2020-07-07 15:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 5:57 What's cooking in git.git (Jul 2020, #01; Mon, 6) Junio C Hamano
2020-07-07 13:29 ` sg/commit-graph-cleanups (was Re: What's cooking in git.git (Jul 2020, #01; Mon, 6)) Derrick Stolee
2020-07-07 15:10 ` Junio C Hamano
2020-07-07 15:12 ` Junio C Hamano [this message]
2020-07-07 16:00 ` Derrick Stolee
2020-07-07 16:45 ` Junio C Hamano
2020-07-07 16:49 ` Taylor Blau
2020-07-07 17:21 ` SZEDER Gábor
2020-07-07 18:12 ` Junio C Hamano
2020-07-10 21:13 ` SZEDER Gábor
2020-07-10 21:38 ` Junio C Hamano
2020-07-08 14:31 ` mr/bisect-in-c-2, was Re: What's cooking in git.git (Jul 2020, #01; Mon, 6) Johannes Schindelin
2020-07-08 15:43 ` Junio C Hamano
2020-07-08 23:11 ` Junio C Hamano
2020-07-09 9:20 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzh8b5pgv.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).