From: Junio C Hamano <firstname.lastname@example.org> To: "Matthew Rogers via GitGitGadget" <email@example.com> Cc: firstname.lastname@example.org, email@example.com, Matthew Rogers <firstname.lastname@example.org> Subject: Re: [PATCH v3] diff: teach --stat to ignore uninteresting modifications Date: Wed, 19 Aug 2020 17:56:24 -0700 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <firstname.lastname@example.org> (Matthew Rogers via GitGitGadget's message of "Thu, 20 Aug 2020 00:41:32 +0000") "Matthew Rogers via GitGitGadget" <email@example.com> writes: > From: Matthew Rogers <firstname.lastname@example.org> > > When options such as --ignore-space-change are in use, files with > modifications can have no interesting textual changes worth showing. In > such cases, "git diff --stat" shows 0 lines of additions and deletions. > Teach "git diff --stat" not to show such a path in its output, which > would be more natural. > > However, we don't want to prevent the display of all files that have 0 > effective diffs since they could be the result of a rename, permission > change, or other similar operation that may still be of interest so we > special case additions and deletions as they are always interesting. > > Signed-off-by: Matthew Rogers <email@example.com> > --- Looks good, thanks. Will queue. By the way, before making your commits, please make sure you do not have whitespace errors. I've let my "git am" to fix them, so no need to resend, but for future reference... .git/rebase-apply/patch:116: trailing whitespace. struct diffstat_file *file = .git/rebase-apply/patch:119: trailing whitespace. * Omit diffstats of modified files where nothing changed. .git/rebase-apply/patch:122: trailing whitespace. * .git/rebase-apply/patch:124: trailing whitespace. * renames, and mode changes as adding an empty file, .git/rebase-apply/patch:127: trailing whitespace. if ((p->status == DIFF_STATUS_MODIFIED) warning: 5 lines applied after fixing whitespace errors. Applying: diff: teach --stat to ignore uninteresting modifications
prev parent reply other threads:[~2020-08-20 0:56 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-01 23:33 [PATCH] " Matthew Rogers via GitGitGadget 2020-08-02 0:31 ` Junio C Hamano 2020-08-02 1:51 ` Matt Rogers 2020-08-14 22:45 ` [PATCH v2] " Matthew Rogers via GitGitGadget 2020-08-17 21:39 ` Junio C Hamano 2020-08-17 22:37 ` Matt Rogers 2020-08-17 22:37 ` Matt Rogers 2020-08-20 0:41 ` [PATCH v3] " Matthew Rogers via GitGitGadget 2020-08-20 0:56 ` Junio C Hamano [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH v3] diff: teach --stat to ignore uninteresting modifications' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).