From: Junio C Hamano <gitster@pobox.com>
To: nate@roosteregg.cc
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] notes.c: fix a segfault in notes_display_config()
Date: Sun, 22 Nov 2020 22:59:31 -0800 [thread overview]
Message-ID: <xmqqzh38o8x8.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20201123032342.24566-2-nate@roosteregg.cc> (nate@roosteregg.cc's message of "Sun, 22 Nov 2020 22:23:41 -0500")
nate@roosteregg.cc writes:
> if (*load_refs && !strcmp(k, "notes.displayref")) {
> if (!v)
> - config_error_nonbool(k);
> + return config_error_nonbool(k);
"git grep config_error_nonbool" tells us that this is the only
instance that ignores the return value from the function and does
not cause the caller to die.
Looks good. Thanks.
next prev parent reply other threads:[~2020-11-23 7:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-23 3:23 [PATCH 0/2] Fix a segfault in git log --notes nate
2020-11-23 3:23 ` [PATCH 1/2] notes.c: fix a segfault in notes_display_config() nate
2020-11-23 6:59 ` Junio C Hamano [this message]
2020-11-23 3:23 ` [PATCH 2/2] t3301: test proper exit response to no-value notes.displayRef nate
2020-11-23 18:44 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzh38o8x8.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=nate@roosteregg.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).