From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id AFE241FB0A for ; Thu, 3 Dec 2020 18:15:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726479AbgLCSNo (ORCPT ); Thu, 3 Dec 2020 13:13:44 -0500 Received: from pb-smtp2.pobox.com ([64.147.108.71]:53497 "EHLO pb-smtp2.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726309AbgLCSNo (ORCPT ); Thu, 3 Dec 2020 13:13:44 -0500 Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 0C169A6475; Thu, 3 Dec 2020 13:13:01 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=N6fg9uANsPVx ZSH33/35gr1Ojqo=; b=uuwmpN2OPS5c2tw+xaIAHjgTBaHVvUzqNIc2t3Y+gW4p yGvM/VbJQVS15Y+iSacGB5DxxzUXXBB/MleffiUigXxedEr+l9GP7A9VjB4g+8LK a9vMyAhMrXyIQ/pshAHHRHGG8DuI/Wr0szD3ewKVWO0C+Cjv1V+JAT+e7yfcGls= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; q=dns; s=sasl; b=CqDrjd uC9ZQf9V8Cpn9oqRwiEWS+gzT9+0QQleLScn6T+TgW9wmskWVDoQNyIgqdpxt1i9 WWwkeIASjPxjkMujp5jozu3xDDWLFxHSl1pRNRpdmQm6xFIbVo7z8hovnivTGDDn /hzP1um0WgUOuFwICWiuJxc4hYFjA6Gaft+ls= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id BE739A6474; Thu, 3 Dec 2020 13:13:00 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.75.7.245]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id EEC90A6473; Thu, 3 Dec 2020 13:12:59 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: Peter =?utf-8?Q?K=C3=A4stle?= Cc: Philippe Blain , Ralf Thielow , Git mailing list Subject: Re: BUG in fetching non-checked out submodule References: <04968f5c-c8bd-c57e-d646-7c9f7691e1a8@nokia.com> <0b6a34a0-428e-5fc4-307d-1217b112659c@nokia.com> Date: Thu, 03 Dec 2020 10:12:59 -0800 In-Reply-To: <0b6a34a0-428e-5fc4-307d-1217b112659c@nokia.com> ("Peter =?utf-8?Q?K=C3=A4stle=22's?= message of "Thu, 3 Dec 2020 16:33:37 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Pobox-Relay-ID: 2D36B9FA-3593-11EB-8EF8-74DE23BA3BAF-77302942!pb-smtp2.pobox.com Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Peter K=C3=A4stle writes: > On quick glance this sounds plausible, but to fully understand it I > need to put some effort in reading this code again. I hope to do so=20 > tomorrow. We can then compile a new set of patches including this > real fix and Ralf's and my test case. > > Thanks for digging into it. Yeah, thanks, both for noticing problem so quickly and started digging to find the real solution. By the way, as to the "if this were originally two patches, we could have saved the test that expects failure" you raised, I do not think it is a good idea to optimize for cases where changes turn out problematic and have to get reverted.