From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <git-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS shortcircuit=no
	autolearn=ham autolearn_force=no version=3.4.2
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by dcvr.yhbt.net (Postfix) with ESMTP id C09EF1F934
	for <e@yhbt.net>; Tue, 15 Dec 2020 21:09:55 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728416AbgLOVJJ (ORCPT <rfc822;e@yhbt.net>);
        Tue, 15 Dec 2020 16:09:09 -0500
Received: from pb-smtp1.pobox.com ([64.147.108.70]:52381 "EHLO
        pb-smtp1.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1728336AbgLOVJD (ORCPT <rfc822;git@vger.kernel.org>);
        Tue, 15 Dec 2020 16:09:03 -0500
Received: from pb-smtp1.pobox.com (unknown [127.0.0.1])
        by pb-smtp1.pobox.com (Postfix) with ESMTP id DD475835B2;
        Tue, 15 Dec 2020 16:08:19 -0500 (EST)
        (envelope-from junio@pobox.com)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc
        :subject:references:date:in-reply-to:message-id:mime-version
        :content-type; s=sasl; bh=S8NKKEdQK62JoXMWEYfWrMBmwFw=; b=VBbU98
        Iqmay4sRHp61LjuaoDKc7qoy3jzAJmRmE1lzBgTpINjYEv2yuc8AANU8+tnfUqVo
        2zHXoOwBP/s03NnzPWkqQSQ2mLzccIzI9aV6gC3+3ofOBfUB06wc9ipwhhkalHTY
        l28/N7AMBSQN6KWGNXQmrGg8871QJpCnxpxsY=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc
        :subject:references:date:in-reply-to:message-id:mime-version
        :content-type; q=dns; s=sasl; b=yavsg9XriRnVmLM/O6WX43dMKmuvnNTh
        +Jj7LQ0BNrhdsSrj19nt1Pr6MVQ6VKcATpEZCioE3MTOeqgdwjaPGP0iAo1yTPAE
        Uw6QEv8lxiTLuQYxarFdA/4jLTiF634RYQNinUPcpKsqxeQHzmlGhUAjbef8qjya
        iADorCsdQQs=
Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1])
        by pb-smtp1.pobox.com (Postfix) with ESMTP id D3D38835B1;
        Tue, 15 Dec 2020 16:08:19 -0500 (EST)
        (envelope-from junio@pobox.com)
Received: from pobox.com (unknown [35.196.173.25])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 2CFA0835B0;
        Tue, 15 Dec 2020 16:08:19 -0500 (EST)
        (envelope-from junio@pobox.com)
From:   Junio C Hamano <gitster@pobox.com>
To:     Elijah Newren <newren@gmail.com>
Cc:     Jeff King <peff@peff.net>,
        "Randall S. Becker" <rsbecker@nexbridge.com>,
        Git Mailing List <git@vger.kernel.org>
Subject: Re: [ANNOUNCE] git-2.30.0-rc0 - Compile Fails on HPE NonStop
References: <035d01d6d26e$8c255260$a46ff720$@nexbridge.com>
        <xmqqeejraiw7.fsf@gitster.c.googlers.com>
        <X9glBJnlLMTW6Dns@coredump.intra.peff.net>
        <CABPp-BEnkQahdVJP+rfQho+S_hcS3y-o3cZBUMhU-EQHjJTLOQ@mail.gmail.com>
Date:   Tue, 15 Dec 2020 13:08:18 -0800
In-Reply-To: <CABPp-BEnkQahdVJP+rfQho+S_hcS3y-o3cZBUMhU-EQHjJTLOQ@mail.gmail.com>
        (Elijah Newren's message of "Tue, 15 Dec 2020 08:21:37 -0800")
Message-ID: <xmqqzh2e7p6l.fsf@gitster.c.googlers.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Pobox-Relay-ID: A81B5FE2-3F19-11EB-BDF0-D152C8D8090B-77302942!pb-smtp1.pobox.com
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org

Elijah Newren <newren@gmail.com> writes:

> Doh, sorry for the bug.  Yeah, that's the exact fix I'd make.  Junio,
> do you want to just use the changes you've already got, or would you
> like me to submit a patch removing these two 'return's?

Nah, the other half of the reported issue was mine, so let me see if
I can quickly whip up a two-patch series.

Thanks.