From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 54BEF1F9FD for ; Tue, 23 Feb 2021 07:51:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232008AbhBWHtU (ORCPT ); Tue, 23 Feb 2021 02:49:20 -0500 Received: from pb-smtp21.pobox.com ([173.228.157.53]:51044 "EHLO pb-smtp21.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230248AbhBWHtS (ORCPT ); Tue, 23 Feb 2021 02:49:18 -0500 Received: from pb-smtp21.pobox.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 9494E108A1B; Tue, 23 Feb 2021 02:48:36 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=bAKEl6Fy1ZE3FFZZj1NKdVaRtYk=; b=mWKORy lnpRCPm1+Z0Kkv9hTscx3eGjA1UxsQbzicAMkYh4KWR/cQzbzfr4SgTL72h+617u MC2E+NuH7bdKJATyuaKHSpZVcwIu1UIFFvEtMzXXZiGgFU/qj2yNJUqRHWbXN5a8 TLzkuWq9BYNc5Cd6enbpV4Jh0JfiaV1hJIQXw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=YWuUQWs8xxrXApOOypz+8WcscqPYB2in X69KbZGnc29qwlX565Gc02xr6RsAURVhhZ7WAf9jDpOqHtowWC2D6pSFSUyl1WQE Nk+XPQvC2fc0rUkuPBICwFqx+KsVvzugQngJ2s9Zfsvt+ixaX6I0/nEP4LgVN8Hr DrBL7YmqW4M= Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 8C56C108A1A; Tue, 23 Feb 2021 02:48:36 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.74.119.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp21.pobox.com (Postfix) with ESMTPSA id CA200108A19; Tue, 23 Feb 2021 02:48:33 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: Denton Liu Cc: Git Mailing List , Eric Sunshine Subject: Re: [PATCH v2] git-cat-file.txt: remove references to "sha1" References: <4030a678b923ca6a49b4e5bc6f0cdf4cf6ae7037.1614064618.git.liu.denton@gmail.com> Date: Mon, 22 Feb 2021 23:48:32 -0800 In-Reply-To: <4030a678b923ca6a49b4e5bc6f0cdf4cf6ae7037.1614064618.git.liu.denton@gmail.com> (Denton Liu's message of "Mon, 22 Feb 2021 23:17:33 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 8784AA9A-75AB-11EB-979E-D609E328BF65-77302942!pb-smtp21.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Denton Liu writes: > `objectname`:: > - The 40-hex object name of the object. > + The full hex representation of the object ID of the object. While I agree that it is a good idea to move away from an explicit mention of "40", I do not see why we would want to explain "object name" not as "object name" but as "object ID". IOW, s/ID/name/. > @@ -215,8 +215,9 @@ newline. The available atoms are: > > `deltabase`:: > If the object is stored as a delta on-disk, this expands to the > - 40-hex sha1 of the delta base object. Otherwise, expands to the > - null sha1 (40 zeroes). See `CAVEATS` below. > + full hex representation of the object ID of the delta base > + object. Otherwise, expands to the null OID (all zeroes). See > + `CAVEATS` below. Likewise. Documentation/glossary-content.txt says "object name" is the canonical term, with "object identifier", "hash" etc. as its synonyms. > @@ -235,14 +236,14 @@ newline. > For example, `--batch` without a custom format would produce: > > ------------ > - SP SP LF > + SP SP LF > LF > ------------ > > Whereas `--batch-check='%(objectname) %(objecttype)'` would produce: > > ------------ > - SP LF > + SP LF > ------------ These look good. Thanks.