From: Junio C Hamano <gitster@pobox.com>
To: "Đoàn Trần Công Danh" <congdanhqx@gmail.com>
Cc: Hu Jialun <hujialun@comp.nus.edu.sg>, git@vger.kernel.org
Subject: Re: [PATCH v2 1/2] commit: reorganise duplicate commit prompt strings
Date: Wed, 07 Jul 2021 10:44:30 -0700 [thread overview]
Message-ID: <xmqqzguydnnl.fsf@gitster.g> (raw)
In-Reply-To: <YOXc+mT01vptY9Nx@danh.dev> ("Đoàn Trần Công Danh"'s message of "Wed, 7 Jul 2021 23:57:30 +0700")
Đoàn Trần Công Danh <congdanhqx@gmail.com> writes:
> However, I think we shouldn't take this route, because splitting likes this
> will make a translation lego. I can't speak for Junio, but from my
> observation, it's preferred to have 3 variables for 3 full-text, and
> we will pick the suitable text in each if-leg.
Yes, that is what I meant in my earlier suggestion. More like
char *hint_cleanup_all =
_("Please enter the ... , and an empty message aborts the commit.\n");
char *hint_cleanup_space =
_("Please enter the ... if you want to.\n"
"An empty message aborts the commit.\n");
if (allow_empty_message) {
hint_cleanup_all = _("...");
hint_cleanup_space = _("...");
}
... the if/elseif cascade in which calls to status_printf() are made
... using these variables
Thanks.
next prev parent reply other threads:[~2021-07-07 17:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-06 2:24 [PATCH] commit: remove irrelavent prompt on `--allow-empty-message` Hu Jialun
2021-07-06 15:44 ` Junio C Hamano
2021-07-07 4:37 ` Felipe Contreras
2021-07-07 10:43 ` Hu Jialun
2021-07-07 16:23 ` Hu Jialun
2021-07-07 16:23 ` [PATCH v2 1/2] commit: reorganise duplicate commit prompt strings Hu Jialun
2021-07-07 16:57 ` Đoàn Trần Công Danh
2021-07-07 17:44 ` Junio C Hamano [this message]
2021-07-07 16:23 ` [PATCH v2 2/2] commit: remove irrelavent prompt on `--allow-empty-message` Hu Jialun
2021-07-07 17:42 ` Felipe Contreras
2021-07-08 15:19 ` [PATCH] " Hu Jialun
2021-07-08 16:05 ` Đoàn Trần Công Danh
2021-07-08 18:26 ` Junio C Hamano
2021-07-09 18:07 ` [PATCH v3 1/2] commit: reorganise commit hint strings Hu Jialun
2021-07-09 19:14 ` Junio C Hamano
2021-07-09 18:07 ` [PATCH v3 2/2] commit: remove irrelavent prompt on `--allow-empty-message` Hu Jialun
2021-07-09 19:14 ` Junio C Hamano
2021-07-10 17:26 ` Hu Jialun
2021-07-22 18:33 ` Hu Jialun
2021-07-22 21:18 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzguydnnl.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=congdanhqx@gmail.com \
--cc=git@vger.kernel.org \
--cc=hujialun@comp.nus.edu.sg \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).