git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Elijah Newren <newren@gmail.com>
Cc: Jeff King <peff@peff.net>, Yuri <yuri@rawbw.com>,
	Git Mailing List <git@vger.kernel.org>
Subject: Re: 'git pull' complains that a locally resurrected directory would be overwritten by merge when no pulled changes are affecting that directory
Date: Wed, 25 Aug 2021 14:19:15 -0700	[thread overview]
Message-ID: <xmqqzgt5gr3g.fsf@gitster.g> (raw)
In-Reply-To: <CABPp-BEMXW3EOdT4jt1g63uPyZ5YuKUPfBE9BL=E66QcT5uXXA@mail.gmail.com> (Elijah Newren's message of "Wed, 25 Aug 2021 08:42:09 -0700")

Elijah Newren <newren@gmail.com> writes:

> ... allow if the incoming changes don't touch the same files), but
> local *staged* changes.  As per the merge manpage:
>
> """
> To avoid recording unrelated changes in the merge commit, git pull and
> git merge will also abort if there are any changes registered in the
> index relative to the HEAD commit.
> """
>
> While this particular example could theoretically be handled by the
> merge machinery without requiring the index match HEAD,...

While I do not mind seeing a patch that loosens the condition ONLY
when the merge will cleanly auto-resolve without end-user
interaction, when any paths conflict and require editing by the
end-user, it is pretty much essential to require that the index
matches HEAD to keep "git merge" usable. 

This is because the final step to conclude such an "automated
procedure cannot cleanly resolve, so the end user helps resolving
with the editor and mark the resolved paths with 'git add' or 'git
rm'" session will become very error prone if we did not have the
requirement.  Not just the user MUST remember not to use "commit -a"
or "git add" a path that was already dirty in the working tree
before the merge started (which is the consequence of the current
requirement, which allows local changes to the unrelated working
tree files), they must MUST remember to somehow EXCLUDE the changes
already registered for unrelted paths from the concluded merge.

  parent reply	other threads:[~2021-08-25 21:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-24 16:41 'git pull' complains that a locally resurrected directory would be overwritten by merge when no pulled changes are affecting that directory Yuri
2021-08-25  1:05 ` Jeff King
2021-08-25 15:42   ` Elijah Newren
2021-08-25 19:05     ` Jeff King
2021-08-25 21:19     ` Junio C Hamano [this message]
2021-08-27  1:05       ` Jeff King
2021-08-28  5:21         ` Elijah Newren
2021-08-25  5:43 ` Bagas Sanjaya
2021-08-25  5:47   ` Yuri

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqzgt5gr3g.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=newren@gmail.com \
    --cc=peff@peff.net \
    --cc=yuri@rawbw.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).