From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 7C0E61F8C6 for ; Mon, 30 Aug 2021 21:23:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237457AbhH3VYT (ORCPT ); Mon, 30 Aug 2021 17:24:19 -0400 Received: from pb-smtp2.pobox.com ([64.147.108.71]:53199 "EHLO pb-smtp2.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236603AbhH3VYT (ORCPT ); Mon, 30 Aug 2021 17:24:19 -0400 Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id E6B90E6D50; Mon, 30 Aug 2021 17:23:24 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=R/aJTwgU6fRqPczvzJcJLcwoHZ8O4smDHP51Na hdDIk=; b=By+mmArQH1KZ87hxPUO6579+o5ddoR4OdmuzEAil2G1dLyLu87iDBr 3Ux1ardx+DT0dacPoQTSA2S0rHozKWq1JklW4Alw/xErhViCHX71enNafzAP7r2R m4ZcrPU4jrXWu0NYLOM7u4HSnHpPXfoEU/T7S4Z9u/H4rV6QrzDeU= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id DE8E5E6D4F; Mon, 30 Aug 2021 17:23:24 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.74.116.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id 613AFE6D4E; Mon, 30 Aug 2021 17:23:24 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: Emily Shaffer Cc: Mahi Kolla via GitGitGadget , git@vger.kernel.org Subject: Re: [PATCH] fixup! clone: set submodule.recurse=true if submodule.stickyRecursiveClone enabled References: Date: Mon, 30 Aug 2021 14:23:23 -0700 In-Reply-To: (Emily Shaffer's message of "Mon, 30 Aug 2021 13:59:02 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 823AFF0A-09D8-11EC-A416-ECFD1DBA3BAF-77302942!pb-smtp2.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Emily Shaffer writes: > On Thu, Aug 19, 2021 at 10:41:03AM -0700, Emily Shaffer wrote: >> >> On Wed, Aug 18, 2021 at 01:15:56PM -0700, Junio C Hamano wrote: >> > >> > Narrow the scope of a temporary variable used only once and >> > immediately die, and rename it to a shorter, throw-away name. >> > >> > Also lose a {} around a single statement block. >> > >> > Signed-off-by: Junio C Hamano >> Acked-by: Emily Shaffer >> >> Thanks. > > Having not heard from Mahi last week, if you are happy with the > patch+squash, I think it would be OK to take this without waiting longer > for her. Up to you of course. Thanks for a nudge.