From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org,
"Carlo Marcelo Arenas Belón" <carenas@gmail.com>,
"Jeff King" <peff@peff.net>,
"Jonathan Nieder" <jrnieder@gmail.com>
Subject: Re: [PATCH v2 2/2] Makefile: pass -Wno-pendantic under GENERATE_COMPILATION_DATABASE=yes
Date: Thu, 23 Sep 2021 14:33:32 -0700 [thread overview]
Message-ID: <xmqqzgs3x9hv.fsf@gitster.g> (raw)
In-Reply-To: <patch-v2-2.2-6b18bd08894-20210922T220532Z-avarab@gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Thu, 23 Sep 2021 00:08:02 +0200")
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> The same bug fixed in the "COMPUTE_HEADER_DEPENDENCIES=auto" mode in
> the preceding commit was also present with
> "GENERATE_COMPILATION_DATABASE=yes". Let's fix it so it works again
> with "DEVOPTS=1".
>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---
> Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Makefile b/Makefile
> index 10ea12aae21..94b116d4b37 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1304,6 +1304,7 @@ endif
>
> ifeq ($(GENERATE_COMPILATION_DATABASE),yes)
> compdb_check = $(shell $(CC) $(ALL_CFLAGS) \
> + -Wno-pedantic \
Yup, I like reusing the same approach from the other fix;
removing $(ALL_CFLAGS) may work fine, too, and that is what I
already queued, but I may swap it out with this later (if I do not
forget, that is).
> -c -MJ /dev/null \
> -x c /dev/null -o /dev/null 2>&1; \
> echo $$?)
next prev parent reply other threads:[~2021-09-23 21:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 10:38 [PATCH] Makefile: make COMPUTE_HEADER_DEPENDENCIES=auto work with DEVOPTS=pedantic Ævar Arnfjörð Bjarmason
2021-09-22 10:55 ` Carlo Arenas
2021-09-22 11:04 ` Ævar Arnfjörð Bjarmason
2021-09-22 16:08 ` Junio C Hamano
2021-09-22 17:04 ` Jeff King
2021-09-22 18:28 ` Junio C Hamano
2021-09-22 18:44 ` Carlo Arenas
2021-09-22 20:17 ` Jeff King
2021-09-22 20:36 ` Carlo Arenas
2021-09-22 22:40 ` Ævar Arnfjörð Bjarmason
2021-09-23 17:32 ` Jeff King
2021-09-23 0:03 ` Junio C Hamano
2021-09-23 16:20 ` Jeff King
2021-09-23 17:41 ` Junio C Hamano
2021-09-22 19:45 ` Ævar Arnfjörð Bjarmason
2021-09-22 22:08 ` [PATCH v2 0/2] Makefile: "pedantic" fallout on .depend and "compdb" Ævar Arnfjörð Bjarmason
2021-09-22 22:08 ` [PATCH v2 1/2] Makefile: make COMPUTE_HEADER_DEPENDENCIES=auto work with DEVOPTS=pedantic Ævar Arnfjörð Bjarmason
2021-09-22 22:08 ` [PATCH v2 2/2] Makefile: pass -Wno-pendantic under GENERATE_COMPILATION_DATABASE=yes Ævar Arnfjörð Bjarmason
2021-09-23 0:05 ` Carlo Arenas
2021-09-23 21:33 ` Junio C Hamano [this message]
2021-09-23 17:38 ` [PATCH v2 0/2] Makefile: "pedantic" fallout on .depend and "compdb" Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzgs3x9hv.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).