From: Junio C Hamano <gitster@pobox.com>
To: Alex Henrie <alexhenrie24@gmail.com>
Cc: git@vger.kernel.org, paulus@ozlabs.org
Subject: Re: [PATCH 3/3] gitk: set log.graph=false when running `git log`
Date: Wed, 09 Feb 2022 10:26:43 -0800 [thread overview]
Message-ID: <xmqqzgmz7v6k.fsf@gitster.g> (raw)
In-Reply-To: <20220209162350.169971-3-alexhenrie24@gmail.com> (Alex Henrie's message of "Wed, 9 Feb 2022 09:23:49 -0700")
Alex Henrie <alexhenrie24@gmail.com> writes:
> Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
> ---
> gitk-git/gitk | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
This may handle "gitk", but what about thousands other scripts
people have developed around "git log", I have to wonder.
> diff --git a/gitk-git/gitk b/gitk-git/gitk
> index 23d9dd1fe0..1d8a5ff622 100755
> --- a/gitk-git/gitk
> +++ b/gitk-git/gitk
> @@ -411,8 +411,9 @@ proc start_rev_list {view} {
> }
>
> if {[catch {
> - set fd [open [concat | git log --no-color -z --pretty=raw $show_notes \
> - --parents --boundary $args "--" $files] r]
> + set fd [open [concat | git -c log.graph=false log --no-color -z \
> + --pretty=raw $show_notes --parents --boundary $args \
> + "--" $files] r]
> } err]} {
> error_popup "[mc "Error executing git log:"] $err"
> return 0
> @@ -559,8 +560,9 @@ proc updatecommits {} {
> set args $vorigargs($view)
> }
> if {[catch {
> - set fd [open [concat | git log --no-color -z --pretty=raw $show_notes \
> - --parents --boundary $args "--" $vfilelimit($view)] r]
> + set fd [open [concat | git -c log.graph=false log --no-color -z \
> + --pretty=raw $show_notes --parents --boundary $args \
> + "--" $vfilelimit($view)] r]
> } err]} {
> error_popup "[mc "Error executing git log:"] $err"
> return
next prev parent reply other threads:[~2022-02-09 18:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-09 16:23 [PATCH 1/3] log: fix memory leak if --graph is passed multiple times Alex Henrie
2022-02-09 16:23 ` [PATCH 2/3] log: add a config option for --graph Alex Henrie
2022-02-09 18:25 ` Junio C Hamano
2022-02-10 16:49 ` Alex Henrie
2022-02-09 16:23 ` [PATCH 3/3] gitk: set log.graph=false when running `git log` Alex Henrie
2022-02-09 18:26 ` Junio C Hamano [this message]
2022-02-10 16:50 ` Alex Henrie
2022-02-10 20:15 ` Junio C Hamano
2022-02-09 18:16 ` [PATCH 1/3] log: fix memory leak if --graph is passed multiple times Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzgmz7v6k.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=alexhenrie24@gmail.com \
--cc=git@vger.kernel.org \
--cc=paulus@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).