From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 818AE1F4D7 for ; Thu, 26 May 2022 17:29:17 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=pobox.com header.i=@pobox.com header.b="XRaxq4tW"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344056AbiEZR3O (ORCPT ); Thu, 26 May 2022 13:29:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238804AbiEZR3L (ORCPT ); Thu, 26 May 2022 13:29:11 -0400 Received: from pb-smtp21.pobox.com (pb-smtp21.pobox.com [173.228.157.53]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 128E7674F2 for ; Thu, 26 May 2022 10:29:10 -0700 (PDT) Received: from pb-smtp21.pobox.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 9941319DD19; Thu, 26 May 2022 13:29:09 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=MhtPHs0JQdrR Drzi7PSuS18t7tyupVdLuBzvJJB8SA4=; b=XRaxq4tWFRBJIy8kYtjdI/2cfdVS yo33QGoldZEwKw3c7UChwWMJpLF7nPxSnA2F1ErkVwHWrdG+5F8x8z6//xiHJZ9p n+q0G707QLlUZmvaU5RH5qWTZdw3TrY4/zST2zMEOU2dQpar9d2wgTX3FkRaRkUN BX4pqJm+OoAs8qU= Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 92E0519DD18; Thu, 26 May 2022 13:29:09 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.83.92.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp21.pobox.com (Postfix) with ESMTPSA id 4A24219DD14; Thu, 26 May 2022 13:29:06 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: Phillip Wood Cc: git@vger.kernel.org Subject: Re: [PATCH] revert: optionally refer to commit in the "reference" format References: <4c8ea23d-1a1d-efd4-6c11-7c08f8728d59@gmail.com> Date: Thu, 26 May 2022 10:29:05 -0700 In-Reply-To: <4c8ea23d-1a1d-efd4-6c11-7c08f8728d59@gmail.com> (Phillip Wood's message of "Thu, 26 May 2022 12:17:33 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Pobox-Relay-ID: 58127B08-DD19-11EC-B370-CBA7845BAAA9-77302942!pb-smtp21.pobox.com Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Phillip Wood writes: > In format-patch we add three asterisks to the beginning and end of the > dummy subject and body lines to encourage the user to edit them - is=20 > that worth doing here as well? Yeah, that would make things consistent. I am still mulling over =C3=86var's idea of preparing the messsage in such a way that, if committed without editing, the title becomes identifiable but too ugly to force users consider rewording (and the "identifiable" part helps the "rebase -i" process), while making it easy to discard the instruction for the user who do want to edit. I think that is the right approach, if we can find one. What has been floated on the list during the discussion is not there yet, but I think the approach is a good one. Thanks.