From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS54825 147.75.192.0/21 X-Spam-Status: No, score=-2.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org [147.75.199.223]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 6E3881F406 for ; Tue, 31 Oct 2023 02:17:42 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=pobox.com header.i=@pobox.com header.a=rsa-sha256 header.s=sasl header.b=w/f5wJ1E; dkim-atps=neutral Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 773BA1C2034B for ; Tue, 31 Oct 2023 02:17:41 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3A8E31879; Tue, 31 Oct 2023 02:17:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=pobox.com header.i=@pobox.com header.b="w/f5wJ1E" Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65C01805 for ; Tue, 31 Oct 2023 02:17:31 +0000 (UTC) Received: from pb-smtp2.pobox.com (pb-smtp2.pobox.com [64.147.108.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3B0D811F for ; Mon, 30 Oct 2023 19:17:29 -0700 (PDT) Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 23CF61B948E; Mon, 30 Oct 2023 22:17:28 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version :content-type; s=sasl; bh=1NJyYLlosYpj6+ZM0qNY5ZNAue8lQeJ9h9OFjn 5OK7M=; b=w/f5wJ1EUdJ4f+09Cnejb/NVN61zy5EMDofjNz9fgMa7PpBCRcSJs/ LD9ACmI5CE2vyO+ikJoLjQDuT87yGjqWOGriHwhk8QkwBoBULUjiFCzsPY32wm7a GKk3OgUnDTrhElbaP3RC78uS7PjT3TaQzWJZAljwR5SRUfPg0RT8g= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 193C91B948C; Mon, 30 Oct 2023 22:17:28 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.125.198.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id 7678E1B948B; Mon, 30 Oct 2023 22:17:27 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: Phillip Wood Cc: Eric Sunshine , emilyshaffer@google.com, git@vger.kernel.org, Emily Shaffer , Sheik , Dragan Simic Subject: Re: [PATCH v3] bugreport: reject positional arguments In-Reply-To: (Junio C. Hamano's message of "Tue, 31 Oct 2023 08:31:28 +0900") References: <20231026005542.872301-1-nasamuffin@google.com> <20231026155459.2234929-1-nasamuffin@google.com> <3e15f266-c790-4b71-84b6-1328339425c1@gmail.com> <881c7fea-47bb-45a9-b6e3-314f9ed9e0cd@gmail.com> Date: Tue, 31 Oct 2023 11:17:26 +0900 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: , MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: A315BE7E-7793-11EE-8273-25B3960A682E-77302942!pb-smtp2.pobox.com List-Unsubscribe-Post: List-Unsubscribe=One-Click Junio C Hamano writes: > Phillip Wood writes: > >> ... it is determining that grep >> failed in the first place that I find annoying. I've also found the >> output from test_i18ngrep is helpful when debugging CI test failures. > > Thanks, I agree with you that it is very useful for debugging to > have an explicit "I did not find what I expected to see". On the > other hand, the other side is not as severe a problem, I think. If > "grep" expects not to see an error message in the output but the > output has the error we do not want to see, we will see the message > in the "-v" output when we run test. Everything I wrote above makes sense, but what I continued this message with (below---omitted) is total opposite. Let's discard and maybe retry sometime later.