From: Junio C Hamano <gitster@pobox.com>
To: Duy Nguyen <pclouds@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] Move test-* to t/helper/ subdirectory
Date: Wed, 27 Apr 2016 09:15:41 -0700 [thread overview]
Message-ID: <xmqqy47z9geq.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20160427101833.GA5536@lanh> (Duy Nguyen's message of "Wed, 27 Apr 2016 17:18:34 +0700")
Duy Nguyen <pclouds@gmail.com> writes:
> This patch forces bin-wrappers regeneration every time a test program
> is updated. A bit wasteful, but I don't see a better option (which is
> also why I limit this to test programs only).
In other words, when we update the location where the programs that
would be eventually installed are created, we'd see the same
problem.
I actually wonder if it is a better overall structure to move
t/helper/test-foo back to test-foo, while keeping the source file
that contains main() for test-foo at t/helper/test-foo.c. Then we
do not have to have many copies that are slightly different in
bin-wrappers, but they can all be
exec "${GIT_EXEC_PATH}/$0" "$@"
instead of "bin-wrappers/git-bar" being
exec "${GIT_EXEC_PATH}/git-bar" "$@"
and "bin-wrappers/test-foo" being
exec "${GIT_EXEC_PATH}/t/helper/test-foo" "$@"
next prev parent reply other threads:[~2016-04-27 16:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-13 13:22 [PATCH] Move test-* to t/helper/ subdirectory Nguyễn Thái Ngọc Duy
2016-04-15 15:09 ` Junio C Hamano
2016-04-15 17:06 ` Junio C Hamano
2016-04-16 0:08 ` Duy Nguyen
2016-04-26 22:07 ` Junio C Hamano
2016-04-27 0:52 ` Duy Nguyen
2016-04-27 10:18 ` Duy Nguyen
2016-04-27 16:15 ` Junio C Hamano [this message]
2016-05-01 0:28 ` Duy Nguyen
2016-05-01 6:00 ` Duy Nguyen
2016-05-02 17:34 ` Junio C Hamano
2016-05-03 0:15 ` Duy Nguyen
2016-05-08 9:51 ` Duy Nguyen
2016-05-09 16:03 ` Junio C Hamano
2016-05-10 11:58 ` Duy Nguyen
2016-05-10 20:23 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2011-02-09 22:15 [PATCH/RFC] Move test-*.c to test/ subdirectory Junio C Hamano
2011-02-10 2:14 ` [PATCH] Move test-* to t/helper/ subdirectory Nguyễn Thái Ngọc Duy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy47z9geq.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).