From: Junio C Hamano <gitster@pobox.com>
To: Stefan Beller <sbeller@google.com>
Cc: git@vger.kernel.org, Jens.Lehmann@web.de
Subject: Re: [PATCH 05/10] submodule add: send messages to stderr
Date: Mon, 02 May 2016 16:26:40 -0700 [thread overview]
Message-ID: <xmqqy47soxcf.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <1461976845-18228-6-git-send-email-sbeller@google.com> (Stefan Beller's message of "Fri, 29 Apr 2016 17:40:40 -0700")
Stefan Beller <sbeller@google.com> writes:
> Reroute the output of stdout to stderr as it is just informative
> messages, not to be consumed by machines.
>
> This should not regress any scripts that try to parse the
> current output, as the output is already internationalized
> and therefore unstable.
>
> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---
Sounds sensible.
> git-submodule.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/git-submodule.sh b/git-submodule.sh
> index d689265..f4d500e 100755
> --- a/git-submodule.sh
> +++ b/git-submodule.sh
> @@ -271,7 +271,7 @@ Use -f if you really want to add it." >&2
> echo >&2 "$(eval_gettext "use the '--force' option. If the local git directory is not the correct repo")"
> die "$(eval_gettext "or you are unsure what this means choose another name with the '--name' option.")"
> else
> - echo "$(eval_gettext "Reactivating local git directory for submodule '\$sm_name'.")"
> + echo >&2 "$(eval_gettext "Reactivating local git directory for submodule '\$sm_name'.")"
> fi
> fi
> git submodule--helper clone ${GIT_QUIET:+--quiet} --prefix "$wt_prefix" --path "$sm_path" --name "$sm_name" --url "$realrepo" "$reference" "$depth" || exit
next prev parent reply other threads:[~2016-05-02 23:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-30 0:40 [PATCH 00/10] submodule output patches Stefan Beller
2016-04-30 0:40 ` [PATCH 01/10] submodule deinit test: fix broken && chain in subshell Stefan Beller
2016-04-30 0:40 ` [PATCH 02/10] submodule deinit: lose requirement for giving '.' Stefan Beller
2016-04-30 0:40 ` [PATCH 03/10] submodule init: redirect stdout to stderr Stefan Beller
2016-04-30 0:40 ` [PATCH 04/10] shell helpers usage: always send help " Stefan Beller
2016-05-02 23:28 ` Junio C Hamano
2016-05-02 23:44 ` Stefan Beller
2016-05-03 0:45 ` Junio C Hamano
2016-05-03 1:17 ` Junio C Hamano
2016-04-30 0:40 ` [PATCH 05/10] submodule add: send messages " Stefan Beller
2016-05-02 23:26 ` Junio C Hamano [this message]
2016-04-30 0:40 ` [PATCH 06/10] submodule deinit: " Stefan Beller
2016-05-02 23:28 ` Junio C Hamano
2016-04-30 0:40 ` [PATCH 07/10] submodule foreach: " Stefan Beller
2016-04-30 0:40 ` [PATCH 08/10] submodule update: " Stefan Beller
2016-04-30 0:40 ` [PATCH 09/10] submodule sync: " Stefan Beller
2016-04-30 0:40 ` [PATCH 10/10] submodule deinit: complain when given a file instead of a submodule Stefan Beller
2016-05-02 8:26 ` Per Cederqvist
2016-05-02 16:21 ` Stefan Beller
2016-05-02 17:00 ` Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy47soxcf.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).