From: Junio C Hamano <gitster@pobox.com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: Pranit Bauva <pranit.bauva@gmail.com>,
git@vger.kernel.org, larsxschneider@gmail.com,
chriscool@tuxfamily.org, christian.couder@gmail.com,
peff@peff.net
Subject: Re: [PATCH] builtin/commit.c: memoize git-path for COMMIT_EDITMSG
Date: Tue, 24 May 2016 15:25:00 -0700 [thread overview]
Message-ID: <xmqqy46z2iwz.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <vpq1t4rri2a.fsf@anie.imag.fr> (Matthieu Moy's message of "Tue, 24 May 2016 10:11:57 +0200")
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
>> More importantly, when is this function evaluated and returned value
>> used to fill commit_editmsg_path[]?
>
> I may have missed something, but I'd say "never", as the code is not
> compilable at least with my gcc:
It was a rhetorical question ;-) But "the more important part" was
that initialization by calling non-trivial function is not a good
idea even in C++ where it is allowed, as you said below.
> And indeed, this construct is a huge source of trouble, as it would mean
> that git_path_commit_editmsg() is called 1) unconditionnally, and 2)
> before entering main().
Indeed. Thanks.
next prev parent reply other threads:[~2016-05-24 22:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-23 18:16 [PATCH] builtin/commit.c: memoize git-path for COMMIT_EDITMSG Pranit Bauva
2016-05-23 19:16 ` Junio C Hamano
2016-05-24 5:54 ` Pranit Bauva
2016-05-24 6:35 ` Pranit Bauva
2016-05-24 8:11 ` Matthieu Moy
2016-05-24 11:41 ` Pranit Bauva
2016-05-24 22:25 ` Junio C Hamano [this message]
2016-05-24 19:19 ` [PATCH v2] " Pranit Bauva
2016-06-07 14:55 ` Pranit Bauva
2016-06-09 6:58 ` Jeff King
2016-06-09 9:54 ` Pranit Bauva
2016-06-09 17:04 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy46z2iwz.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=chriscool@tuxfamily.org \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=larsxschneider@gmail.com \
--cc=peff@peff.net \
--cc=pranit.bauva@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).