From: Junio C Hamano <gitster@pobox.com>
To: Han-Wen Nienhuys <hanwen@google.com>
Cc: git <git@vger.kernel.org>
Subject: Re: [PATCH 2/2] sideband: highlight keywords in remote sideband output
Date: Mon, 06 Aug 2018 15:12:11 -0700 [thread overview]
Message-ID: <xmqqy3djm9fo.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <CAFQ2z_OnUHcJSryq7vTdkvBuna64y0Q3+C+NX7o4_tFwSqjcDg@mail.gmail.com> (Han-Wen Nienhuys's message of "Mon, 6 Aug 2018 16:06:12 +0200")
Han-Wen Nienhuys <hanwen@google.com> writes:
>> If your "make test" did not catch this as an error, then we may need
>> to fix t/Makefile, as it is supposed to run test-lint.
>
> I've been running tests individually as
>
> sh t5409-colorize-remote-messages.sh -v -d
During your own development that may be sufficient, but do run "make
test" to run tests by other people; it will help you catch new bugs
you are introducing whey they notice their expectations are broken.
You are breaking 5541 (there may be others, but I noticed a breakage
there) perhaps with your debugging cruft.
next prev parent reply other threads:[~2018-08-06 22:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-02 11:47 [PATCH 0/2 v4] sideband: highlight keywords in remote sideband output Han-Wen Nienhuys
2018-08-02 11:47 ` [PATCH 1/2] config: document git config getter return value Han-Wen Nienhuys
2018-08-02 17:37 ` Junio C Hamano
2018-08-02 11:47 ` [PATCH 2/2] sideband: highlight keywords in remote sideband output Han-Wen Nienhuys
2018-08-02 18:22 ` Junio C Hamano
2018-08-06 14:06 ` Han-Wen Nienhuys
2018-08-06 22:12 ` Junio C Hamano [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-08-02 12:13 [PATCH 0/2 v4] " Han-Wen Nienhuys
2018-08-02 12:13 ` [PATCH 2/2] " Han-Wen Nienhuys
2018-08-03 3:48 ` Eric Sunshine
2018-08-03 3:52 ` Jonathan Nieder
2018-08-06 14:17 ` Han-Wen Nienhuys
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy3djm9fo.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=hanwen@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).