git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Derrick Stolee <dstolee@microsoft.com>
Cc: "git\@vger.kernel.org" <git@vger.kernel.org>,
	"johannes.schindelin\@gmx.de" <johannes.schindelin@gmx.de>
Subject: Re: [PATCH] commit: use timestamp_t for author_date_slab
Date: Tue, 21 Aug 2018 14:05:19 -0700	[thread overview]
Message-ID: <xmqqy3cz77n4.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20180821205359.29569-1-dstolee@microsoft.com> (Derrick Stolee's message of "Tue, 21 Aug 2018 20:54:12 +0000")

Derrick Stolee <dstolee@microsoft.com> writes:

> The author_date_slab is used to store the author date of a commit
> when walking with the --author-date flag in rev-list or log. This
> was added as an 'unsigned long' in
>
> 	81c6b38b "log: --author-date-order"
>
> Since 'unsigned long' is ambiguous in its bit-ness across platforms
> (64-bit in Linux, 32-bit in Windows, for example), most references
> to the author dates in commit.c were converted to timestamp_t in
>
> 	dddbad72 "timestamp_t: a new data type for timestamps"
>
> However, the slab definition was missed,

Makes sense, and obviously correct.

> I found this while reading up on the revision-walk machinery. This code
> hasn't been touched in years, so could apply to 'maint'.

Thanks.

      reply	other threads:[~2018-08-21 21:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-21 20:54 [PATCH] commit: use timestamp_t for author_date_slab Derrick Stolee
2018-08-21 21:05 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqy3cz77n4.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=dstolee@microsoft.com \
    --cc=git@vger.kernel.org \
    --cc=johannes.schindelin@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).