From: Junio C Hamano <gitster@pobox.com>
To: Tommi Vainikainen <tvainika@gmail.com>
Cc: sandals@crustytoothpaste.net, git@vger.kernel.org
Subject: Re: git pull defaults for recursesubmodules
Date: Thu, 25 Oct 2018 19:09:19 +0900 [thread overview]
Message-ID: <xmqqy3amficw.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <CAGshahk7pY4rW5SQu73AdHMmxsbDCo5UP5LGF67FQYBws492TA@mail.gmail.com> (Tommi Vainikainen's message of "Wed, 24 Oct 2018 09:57:18 +0300")
Tommi Vainikainen <tvainika@gmail.com> writes:
> After reading SubmittingPatches I didn't find if I should now send a
> fresh patch with
> changes squashed together or new commits appended after first commit in that
> patch. Patch is updated accordingly as fresh patch.
(just on mechanics, not on the contents of your actual patch)
You can and should treat any topic that is not yet in 'next' as if
it did not exist. If you refined based on a v1 patch, pretend as if
you were a perfect developer and you came up with that refined
version without producing any problematic things that were pointed
ont in your v1. Pretend mistakes in v1 never happened. Pretend
that you are perfect! ;-)
If you can limit the signs that an earlier rounds ever existed to
(1) The In-reply-to: header of the message you send your updated
version of the patch in, so that people can find the older
version and its discussion thread, and
(2) The cover letter that describes what you improved in the
updated version relative to the last round, in addition to the
overview of the series [note: this only exists for a larger
patch series, and not usually done for a single patch]
you achieved your goal.
prev parent reply other threads:[~2018-10-25 10:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 21:04 git pull defaults for recursesubmodules Tommi Vainikainen
2018-10-23 21:57 ` Stefan Beller
2018-10-24 5:32 ` Tommi Vainikainen
2018-10-23 23:03 ` brian m. carlson
2018-10-24 6:57 ` Tommi Vainikainen
2018-10-25 10:09 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy3amficw.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=sandals@crustytoothpaste.net \
--cc=tvainika@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).