From: Junio C Hamano <gitster@pobox.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: Derrick Stolee <stolee@gmail.com>, Jeff King <peff@peff.net>,
git <git@vger.kernel.org>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Christian Couder <chriscool@tuxfamily.org>
Subject: Re: [PATCH 2/2] sha1-file: use OBJECT_INFO_NO_FETCH_IF_MISSING
Date: Thu, 20 Jun 2019 13:57:56 -0700 [thread overview]
Message-ID: <xmqqy31wkm97.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <CAP8UFD1-=+32G2XYXARcXm8=hnqZwxa1Ev9nmaS=qfqKS7GSWQ@mail.gmail.com> (Christian Couder's message of "Thu, 20 Jun 2019 16:08:00 +0200")
Christian Couder <christian.couder@gmail.com> writes:
> On Thu, Jun 20, 2019 at 2:39 PM Derrick Stolee <stolee@gmail.com> wrote:
>>
>> On 6/20/2019 4:50 AM, Jeff King wrote:
>> > On Thu, Jun 20, 2019 at 10:30:26AM +0200, Christian Couder wrote:
>> >
>> >> Currently the OBJECT_INFO_FOR_PREFETCH flag is used to check
>> >> if we should fetch objects from promisor remotes when we
>> >> haven't found them elsewhere.
>> >>
>> >> Now that OBJECT_INFO_NO_FETCH_IF_MISSING exists, let's use
>> >> it instead to be more correct in case this new flag is ever
>> >> used without OBJECT_INFO_QUICK.
>> >
>> > I said earlier that this one would need to be tweaked for the new
>> > upstream name. But actually, I think it is not necessary after Stolee's
>> > patch.
>>
>> Yes, I believe that 31f5256c82 does an equivalent thing to the
>> combination of these patches.
>
> Yeah, I agree. Thanks Stolee for having already fixed that, and sorry
> for bothering everyone with this.
OK, I'll stop looking at this patch.
next prev parent reply other threads:[~2019-06-20 20:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-20 8:30 [PATCH 0/2] Add OBJECT_INFO_NO_FETCH_IF_MISSING flag Christian Couder
2019-06-20 8:30 ` [PATCH 1/2] object-store: introduce OBJECT_INFO_NO_FETCH_IF_MISSING Christian Couder
2019-06-20 8:48 ` Jeff King
2019-06-20 8:30 ` [PATCH 2/2] sha1-file: use OBJECT_INFO_NO_FETCH_IF_MISSING Christian Couder
2019-06-20 8:50 ` Jeff King
2019-06-20 12:39 ` Derrick Stolee
2019-06-20 14:08 ` Christian Couder
2019-06-20 20:57 ` Junio C Hamano [this message]
2019-06-20 20:52 ` [PATCH 0/2] Add OBJECT_INFO_NO_FETCH_IF_MISSING flag Junio C Hamano
2019-06-21 10:47 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy31wkm97.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=chriscool@tuxfamily.org \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).