mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <>
To: Paul Mackerras <>
Subject: Re: [PATCH] gitk: Make web links clickable
Date: Wed, 28 Aug 2019 20:46:25 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <20190829005011.GA3297@blackberry> (Paul Mackerras's message of "Thu, 29 Aug 2019 10:50:11 +1000")

Paul Mackerras <> writes:

> I was expecting some comments and suggestions, so I didn't push it out
> yet.  One suggestion which seems reasonable is to match any http or
> https URL anywhere in the commit description, not just with Link: or
> BugLink: at the start of the line.  What do you think of that?  It's
> quite easy to do.  Also it should stop at whitespace rather than going
> to the end of the line.

Yup, that's a quite good suggestion, without little chance of false
positive these days, as we do not have to worry about anything but
http:// and https:// ;-)

In case I forgot to say in my previous message, it's been a while
since we heard from you the last time.  Welcome back ;)

  reply	other threads:[~2019-08-29  3:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-26 22:14 [PATCH] gitk: Make web links clickable Paul Mackerras
2019-08-27 15:33 ` Barret Rhoden
2019-08-27 20:32 ` Junio C Hamano
2019-08-29  0:50   ` Paul Mackerras
2019-08-29  3:46     ` Junio C Hamano [this message]
2019-08-27 21:58 ` Pratyush Yadav
2019-08-29  1:27 ` [PATCH v2] " Paul Mackerras
2019-08-29 18:32   ` Pratyush Yadav
2019-09-13 23:33     ` Paul Mackerras
2019-09-14 14:30       ` Pratyush Yadav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).