From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 2B3111F619 for ; Sat, 22 Feb 2020 17:26:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726631AbgBVR0A (ORCPT ); Sat, 22 Feb 2020 12:26:00 -0500 Received: from pb-smtp20.pobox.com ([173.228.157.52]:55132 "EHLO pb-smtp20.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726198AbgBVR0A (ORCPT ); Sat, 22 Feb 2020 12:26:00 -0500 Received: from pb-smtp20.pobox.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 6FEA6BA27E; Sat, 22 Feb 2020 12:25:59 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=6k2qcVbaqebK2f64oj96E+qloSU=; b=fz43vc j19KkO9kXpNv3UZ9mBxj7ZHv2H+uo/uDTq65cseDZvk779MBJtmKoUtuSC4PpCkV Db5OLO49GFVRpPNHRCOX4PHOELpv5YPruzaozYa9tPKe0mCT6woXv9gIv+NQHc7K wtr3Z6q60vmc+3Qxg5YXFPxsW9mq/2Ss3sCAY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=YFB8rqDFdbCI0HJN3rJfy/hudSQbaAt9 F76wgMmuGtL0EohEXEZW/7qDDo8SADaOx5q/i/OuQzMuyPxRmFEe3sSvaC38FB+6 fgBatfwGFE9+9st9Ggb0mwQ9Zoy35XOoo7RxDg4XWyY/vnevwX5Kgq50An1KmOdQ 6hakOhtcWiI= Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 67E10BA27D; Sat, 22 Feb 2020 12:25:59 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.76.80.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp20.pobox.com (Postfix) with ESMTPSA id 92D2FBA27C; Sat, 22 Feb 2020 12:25:56 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: "Derrick Stolee via GitGitGadget" Cc: git@vger.kernel.org, peff@peff.net, me@ttaylorr.com, jonathantanmy@google.com, jrnieder@gmail.com, sunshine@sunshineco.com, Derrick Stolee Subject: Re: [PATCH v2 0/2] Document two partial clone bugs, fix one References: Date: Sat, 22 Feb 2020 09:25:54 -0800 In-Reply-To: (Derrick Stolee via GitGitGadget's message of "Fri, 21 Feb 2020 21:47:26 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 629E8310-5598-11EA-97FA-B0405B776F7B-77302942!pb-smtp20.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org "Derrick Stolee via GitGitGadget" writes: > While playing with partial clone, I discovered a few bugs and document them > with tests in patch 1. One seems to be a server-side bug that happens in a > somewhat rare situation, but not terribly unlikely. The other is a > client-side bug that leads to quadratic amounts of data transfer; I fix this > bug in patch 2. > > UPDATES in V2: > > * Added "|| return 1" inside the for loops. > > > * Added an in-test comment about the test ordering. > > > * Required protocol.version=2 in the tags test due to the bisect Junio > performed. > > > * Updated the commit message via Jonathan Tan's suggestion. > Now this can safely be queued directly on v2.25.0, I'll rebase it (earlyer I queued it after the merge to make protocol v2 the default). Thanks.