git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: git@vger.kernel.org, Duy Nguyen <pclouds@gmail.com>
Subject: Re: [PATCH 0/3] format-patch: --interiff/--range-diff tweaks
Date: Tue, 08 Sep 2020 15:10:49 -0700	[thread overview]
Message-ID: <xmqqy2ljx6l2.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200908071610.16714-1-sunshine@sunshineco.com> (Eric Sunshine's message of "Tue, 8 Sep 2020 03:16:07 -0400")

Eric Sunshine <sunshine@sunshineco.com> writes:

> This series addresses a few comments[2,3,4,5] which cropped up during
> review of the series which added --interdiff and --range-diff options to
> git-format-patch[1]. That series made it into 'next' before I could address
> the comments, so these patches (based upon 'master') make minor tweaks
> "incrementally" (over 2 years late).

The last step subtly changes the behaviour, if I am reading its
description correctly.  Does it deserve a documentation update, or
are we just making the code behave "better" but still within the
boundary of how it is documented to work, hence no need to update
the doc (but deserves an advertisement in the release notes)?

Thanks.

  parent reply	other threads:[~2020-09-08 22:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-08  7:16 [PATCH 0/3] format-patch: --interiff/--range-diff tweaks Eric Sunshine
2020-09-08  7:16 ` [PATCH 1/3] diff: move show_interdiff() from its own file to diff-lib Eric Sunshine
2020-09-08  7:16 ` [PATCH 2/3] diff-lib: tighten show_interdiff()'s interface Eric Sunshine
2020-09-08  7:16 ` [PATCH 3/3] format-patch: use 'origin' as start of current-series-range when known Eric Sunshine
2020-09-08 22:10 ` Junio C Hamano [this message]
2020-09-09  6:02   ` [PATCH 0/3] format-patch: --interiff/--range-diff tweaks Eric Sunshine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqy2ljx6l2.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=pclouds@gmail.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).