From: Junio C Hamano <gitster@pobox.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org, "SZEDER Gábor" <szeder.dev@gmail.com>
Subject: Re: [PATCH try2 0/4] completion: bash: a bunch of fixes
Date: Wed, 23 Dec 2020 01:14:23 -0800 [thread overview]
Message-ID: <xmqqy2hoanps.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: 20201219140621.1961760-1-felipe.contreras@gmail.com
Felipe Contreras <felipe.contreras@gmail.com> writes:
> This is just the bug fixes from the previous series.
>
> These should be pretty obvious and straightforward.
>
> Felipe Contreras (4):
> completion: bash: fix prefix detection in branch.*
> completion: bash: add correct suffix in variables
> completion: bash: fix for suboptions with value
> completion: bash: fix for multiple dash commands
It seems that this tickles some platform specific glitches in the
tests (the detailed CI report can only be seen when logged in, it
seems):
https://github.com/git/git/runs/1597682180#step:5:35614
The expected output lines have a trailing SP each, while the actual
output lines do not, but this failure happens only on macos job and
not others.
next prev parent reply other threads:[~2020-12-23 9:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-19 14:06 [PATCH try2 0/4] completion: bash: a bunch of fixes Felipe Contreras
2020-12-19 14:06 ` [PATCH try2 1/4] completion: bash: fix prefix detection in branch.* Felipe Contreras
2020-12-19 14:06 ` [PATCH try2 2/4] completion: bash: add correct suffix in variables Felipe Contreras
2020-12-19 14:06 ` [PATCH try2 3/4] completion: bash: fix for suboptions with value Felipe Contreras
2020-12-19 14:06 ` [PATCH try2 4/4] completion: bash: fix for multiple dash commands Felipe Contreras
2020-12-23 9:14 ` Junio C Hamano [this message]
2020-12-23 13:38 ` [PATCH try2 0/4] completion: bash: a bunch of fixes Felipe Contreras
2020-12-23 14:19 ` SZEDER Gábor
2020-12-23 14:31 ` Felipe Contreras
2020-12-23 20:25 ` Junio C Hamano
2020-12-24 0:21 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy2hoanps.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).