Git 2.30.0 and failed self tests

Git 2.30.0 and failed self tests

[Jeffrey Walton]

Hi Everyone,

I'm seeing some failed self tests with 2.30.0 on Fedora 33 x86_64
fully patched. They seem to be centered around email.

    *** t9001-send-email.sh ***
    ok 1 - prepare reference tree
    ok 2 - Setup helper tool
    ok 3 - Extract patches
    not ok 4 - No confirm with --suppress-cc
    #
    #        test_no_confirm --suppress-cc=sob &&
    #        check_no_confirm
    #
    ...

    not ok 174 - test forbidSendmailVariables behavior override
    #
    #        test_config sendmail.program sendmail &&
    #        test_config sendemail.forbidSendmailVariables false &&
    #        git send-email \
    #            --from="Example <nobody@example.com>" \
    #            --to=nobody@example.com \
    #            --smtp-server="$(pwd)/fake.sendmail" \
    #            HEAD^
    #
    # failed 132 among 174 test(s)

Jeff

Git 2.30.0 and failed self tests

[Jeffrey Walton]

Hi Everyone,

I'm seeing a failed self test with 2.30.0 on Alpine Linux 3.10,
x86_64. Alpine Linux uses Musl and BusyBox, so things may be a bit
sideways because of them.

*** t4129-apply-samemode.sh ***
ok 1 - setup
ok 2 - same mode (no index)
ok 3 - same mode (with index)
ok 4 - same mode (index only)
ok 5 - mode update (no index)
ok 6 - mode update (with index)
ok 7 - mode update (index only)
ok 8 - empty mode is rejected
ok 9 - bogus mode is rejected
not ok 10 - do not use core.sharedRepository for working tree files
#
#        git reset --hard &&
#        test_config core.sharedRepository 0666 &&
#        (
#            # Remove a default ACL if possible.
#            (setfacl -k newdir 2>/dev/null || true) &&
#            umask 0077 &&
#
#            # Test both files (f1) and leading dirs (d)
#            mkdir d &&
#            touch f1 d/f2 &&
#            git add f1 d/f2 &&
#            git diff --staged >patch-f1-and-f2.txt &&
#
#            rm -rf d f1 &&
#            git apply patch-f1-and-f2.txt &&
#
#            echo "-rw-------" >f1_mode.expected &&
#            echo "drwx------" >d_mode.expected &&
#            test_modebits f1 >f1_mode.actual &&
#            test_modebits d >d_mode.actual &&
#            test_cmp f1_mode.expected f1_mode.actual &&
#            test_cmp d_mode.expected d_mode.actual
#        )
#
# failed 1 among 10 test(s)
1..10
make[2]: *** [Makefile:57: t4129-apply-samemode.sh] Error 1

I don't see a log file to offer for this one:

    $ find . -name '*.log'
    ./config.log

Jeff

Re: Git 2.30.0 and failed self tests

[Christian Couder]

Hi,

On Sat, Jan 9, 2021 at 12:33 PM Jeffrey Walton <noloader@gmail.com> wrote:

> I'm seeing a failed self test with 2.30.0 on Alpine Linux 3.10,
> x86_64. Alpine Linux uses Musl and BusyBox, so things may be a bit
> sideways because of them.

When a test script fails, could you try going into the "t" directory,
running the test script with -i -v -x and sending the output?

> *** t4129-apply-samemode.sh ***

For example you could run the above test script with:

$ cd t
$ ./t4129-apply-samemode.sh -i -v -x

Thanks for testing!

Christian.

Re: Git 2.30.0 and failed self tests

[Matheus Tavares Bernardino]

Hi, Jeff

On Sat, Jan 9, 2021 at 8:32 AM Jeffrey Walton <noloader@gmail.com> wrote:
>
> Hi Everyone,
>
> I'm seeing a failed self test with 2.30.0 on Alpine Linux 3.10,
> x86_64. Alpine Linux uses Musl and BusyBox, so things may be a bit
> sideways because of them.
>
> *** t4129-apply-samemode.sh ***
> ok 1 - setup
> ok 2 - same mode (no index)
> ok 3 - same mode (with index)
> ok 4 - same mode (index only)
> ok 5 - mode update (no index)
> ok 6 - mode update (with index)
> ok 7 - mode update (index only)
> ok 8 - empty mode is rejected
> ok 9 - bogus mode is rejected
> not ok 10 - do not use core.sharedRepository for working tree files
> #
> #        git reset --hard &&
> #        test_config core.sharedRepository 0666 &&
> #        (
> #            # Remove a default ACL if possible.
> #            (setfacl -k newdir 2>/dev/null || true) &&
> #            umask 0077 &&
> #
> #            # Test both files (f1) and leading dirs (d)
> #            mkdir d &&
> #            touch f1 d/f2 &&
> #            git add f1 d/f2 &&
> #            git diff --staged >patch-f1-and-f2.txt &&
> #
> #            rm -rf d f1 &&
> #            git apply patch-f1-and-f2.txt &&
> #
> #            echo "-rw-------" >f1_mode.expected &&
> #            echo "drwx------" >d_mode.expected &&
> #            test_modebits f1 >f1_mode.actual &&
> #            test_modebits d >d_mode.actual &&
> #            test_cmp f1_mode.expected f1_mode.actual &&
> #            test_cmp d_mode.expected d_mode.actual
> #        )
> #
> # failed 1 among 10 test(s)

Do you happen to have a default ACL rule or the setgid bit set on the
test directory (or a parent directory)? This test is currently failing
under these circumstances, but there are already two patches that fix
these issues:

https://lore.kernel.org/git/b734425e3235651e738e6eac47eae0db7db92e7e.1609861567.git.matheus.bernardino@usp.br/
https://lore.kernel.org/git/20201223114431.4595-1-adam@dinwoodie.org/

Thanks,
Matheus

Re: Git 2.30.0 and failed self tests

[Jeffrey Walton]

[-- Attachment #1: Type: text/plain, Size: 797 bytes --]

On Sat, Jan 9, 2021 at 7:44 AM Christian Couder
<christian.couder@gmail.com> wrote:
>
> On Sat, Jan 9, 2021 at 12:33 PM Jeffrey Walton <noloader@gmail.com> wrote:
>
> > I'm seeing a failed self test with 2.30.0 on Alpine Linux 3.10,
> > x86_64. Alpine Linux uses Musl and BusyBox, so things may be a bit
> > sideways because of them.
>
> When a test script fails, could you try going into the "t" directory,
> running the test script with -i -v -x and sending the output?
>
> > *** t4129-apply-samemode.sh ***
>
> For example you could run the above test script with:
>
> $ cd t
> $ ./t4129-apply-samemode.sh -i -v -x

Thanks Christian and Matheus,

Attached is the redirected output of t4129.

I noticed Alpine does not provide setfacl:

    $ setfacl -k newdir
    -sh: setfacl: not found

Jeff

[-- Attachment #2: t4129.txt --]
[-- Type: text/plain, Size: 11551 bytes --]

Initialized empty Git repository in /home/jwalton/Build-Scripts/git-2.30.0/t/trash directory.t4129-apply-samemode/.git/
expecting success of 4129.1 'setup': 
	echo original >file &&
	git add file &&
	test_tick &&
	git commit -m initial &&
	git tag initial &&
	echo modified >file &&
	git diff --stat -p >patch-0.txt &&
	chmod +x file &&
	git diff --stat -p >patch-1.txt &&
	sed "s/^\(new mode \).*/\1/" <patch-1.txt >patch-empty-mode.txt &&
	sed "s/^\(new mode \).*/\1garbage/" <patch-1.txt >patch-bogus-mode.txt

+ echo original
+ git add file
+ test_tick
+ test -z 
+ test_tick=1112911993
+ GIT_COMMITTER_DATE='1112911993 -0700'
+ GIT_AUTHOR_DATE='1112911993 -0700'
+ export GIT_COMMITTER_DATE GIT_AUTHOR_DATE
+ git commit -m initial
[master (root-commit) e950771] initial
 Author: A U Thor <author@example.com>
 1 file changed, 1 insertion(+)
 create mode 100644 file
+ git tag initial
+ echo modified
+ git diff --stat -p
+ chmod +x file
+ git diff --stat -p
+ sed 's/^\(new mode \).*/\1/'
+ sed 's/^\(new mode \).*/\1garbage/'
ok 1 - setup

checking prerequisite: FILEMODE

mkdir -p "$TRASH_DIRECTORY/prereq-test-dir-FILEMODE" &&
(
	cd "$TRASH_DIRECTORY/prereq-test-dir-FILEMODE" &&
	test "$(git config --bool core.filemode)" = true

)
+ mkdir -p '/home/jwalton/Build-Scripts/git-2.30.0/t/trash directory.t4129-apply-samemode/prereq-test-dir-FILEMODE'
+ cd '/home/jwalton/Build-Scripts/git-2.30.0/t/trash directory.t4129-apply-samemode/prereq-test-dir-FILEMODE'
+ git config --bool core.filemode
+ test true '=' true
prerequisite FILEMODE ok
expecting success of 4129.2 'same mode (no index)': 
	git reset --hard &&
	chmod +x file &&
	git apply patch-0.txt &&
	test -x file

+ git reset --hard
HEAD is now at e950771 initial
+ chmod +x file
+ git apply patch-0.txt
warning: file has type 100755, expected 100644
+ test -x file
ok 2 - same mode (no index)

expecting success of 4129.3 'same mode (with index)': 
	git reset --hard &&
	chmod +x file &&
	git add file &&
	git apply --index patch-0.txt &&
	test -x file &&
	git diff --exit-code

+ git reset --hard
HEAD is now at e950771 initial
+ chmod +x file
+ git add file
+ git apply --index patch-0.txt
warning: file has type 100755, expected 100644
+ test -x file
+ git diff --exit-code
ok 3 - same mode (with index)

expecting success of 4129.4 'same mode (index only)': 
	git reset --hard &&
	chmod +x file &&
	git add file &&
	git apply --cached patch-0.txt &&
	git ls-files -s file | grep "^100755"

+ git reset --hard
HEAD is now at e950771 initial
+ chmod +x file
+ git add file
+ git apply --cached patch-0.txt
warning: file has type 100755, expected 100644
+ git ls-files -s file
+ grep ^100755
100755 2e0996000b7e9019eabcad29391bf0f5c7702f0b 0	file
ok 4 - same mode (index only)

expecting success of 4129.5 'mode update (no index)': 
	git reset --hard &&
	git apply patch-1.txt &&
	test -x file

+ git reset --hard
HEAD is now at e950771 initial
+ git apply patch-1.txt
+ test -x file
ok 5 - mode update (no index)

expecting success of 4129.6 'mode update (with index)': 
	git reset --hard &&
	git apply --index patch-1.txt &&
	test -x file &&
	git diff --exit-code

+ git reset --hard
HEAD is now at e950771 initial
+ git apply --index patch-1.txt
+ test -x file
+ git diff --exit-code
ok 6 - mode update (with index)

expecting success of 4129.7 'mode update (index only)': 
	git reset --hard &&
	git apply --cached patch-1.txt &&
	git ls-files -s file | grep "^100755"

+ git reset --hard
HEAD is now at e950771 initial
+ git apply --cached patch-1.txt
+ git ls-files -s file
+ grep ^100755
100755 2e0996000b7e9019eabcad29391bf0f5c7702f0b 0	file
ok 7 - mode update (index only)

expecting success of 4129.8 'empty mode is rejected': 
	git reset --hard &&
	test_must_fail git apply patch-empty-mode.txt 2>err &&
	test_i18ngrep "invalid mode" err

+ git reset --hard
HEAD is now at e950771 initial
+ test_must_fail git apply patch-empty-mode.txt
+ _test_ok=
+ test_must_fail_acceptable git apply patch-empty-mode.txt
+ test git '=' env
+ return 0
+ git apply patch-empty-mode.txt
+ exit_code=128
+ test 128 -eq 0
+ test_match_signal 13 128
+ test 128 '=' 141
+ test 128 '=' 269
+ return 1
+ test 128 -gt 129
+ test 128 -eq 127
+ test 128 -eq 126
+ return 0
+ test_i18ngrep 'invalid mode' err
+ eval 'last_arg=${2}'
+ last_arg=err
+ test -f err
+ test 2 -lt 2
+ test 'x!' '=' 'xinvalid mode'
+ test_have_prereq '!C_LOCALE_OUTPUT'
+ save_IFS=' 	
'
+ IFS=,
+ set -- '!C_LOCALE_OUTPUT'
+ IFS=' 	
'
+ total_prereq=0
+ ok_prereq=0
+ missing_prereq=
+ negative_prereq=t
+ prerequisite=C_LOCALE_OUTPUT
+ eval 'script=$test_prereq_lazily_C_LOCALE_OUTPUT'
+ script='
	! test_bool_env GIT_TEST_GETTEXT_POISON false
'
+ test_run_lazy_prereq_ C_LOCALE_OUTPUT '
	! test_bool_env GIT_TEST_GETTEXT_POISON false
'
+ script='
mkdir -p "$TRASH_DIRECTORY/prereq-test-dir-C_LOCALE_OUTPUT" &&
(
	cd "$TRASH_DIRECTORY/prereq-test-dir-C_LOCALE_OUTPUT" &&
	! test_bool_env GIT_TEST_GETTEXT_POISON false

)'
+ say 'checking prerequisite: C_LOCALE_OUTPUT'
+ say_color info 'checking prerequisite: C_LOCALE_OUTPUT'
+ test -z info
+ shift
+ printf '%s\n' 'checking prerequisite: C_LOCALE_OUTPUT'
checking prerequisite: C_LOCALE_OUTPUT
+ say '
mkdir -p "$TRASH_DIRECTORY/prereq-test-dir-C_LOCALE_OUTPUT" &&
(
	cd "$TRASH_DIRECTORY/prereq-test-dir-C_LOCALE_OUTPUT" &&
	! test_bool_env GIT_TEST_GETTEXT_POISON false

)'
+ say_color info '
mkdir -p "$TRASH_DIRECTORY/prereq-test-dir-C_LOCALE_OUTPUT" &&
(
	cd "$TRASH_DIRECTORY/prereq-test-dir-C_LOCALE_OUTPUT" &&
	! test_bool_env GIT_TEST_GETTEXT_POISON false

)'
+ test -z info
+ shift
+ printf '%s\n' '
mkdir -p "$TRASH_DIRECTORY/prereq-test-dir-C_LOCALE_OUTPUT" &&
(
	cd "$TRASH_DIRECTORY/prereq-test-dir-C_LOCALE_OUTPUT" &&
	! test_bool_env GIT_TEST_GETTEXT_POISON false

)'

mkdir -p "$TRASH_DIRECTORY/prereq-test-dir-C_LOCALE_OUTPUT" &&
(
	cd "$TRASH_DIRECTORY/prereq-test-dir-C_LOCALE_OUTPUT" &&
	! test_bool_env GIT_TEST_GETTEXT_POISON false

)
+ test_eval_ '
mkdir -p "$TRASH_DIRECTORY/prereq-test-dir-C_LOCALE_OUTPUT" &&
(
	cd "$TRASH_DIRECTORY/prereq-test-dir-C_LOCALE_OUTPUT" &&
	! test_bool_env GIT_TEST_GETTEXT_POISON false

)'
+ test_eval_inner_ '
mkdir -p "$TRASH_DIRECTORY/prereq-test-dir-C_LOCALE_OUTPUT" &&
(
	cd "$TRASH_DIRECTORY/prereq-test-dir-C_LOCALE_OUTPUT" &&
	! test_bool_env GIT_TEST_GETTEXT_POISON false

)'
+ eval '
		want_trace && trace_level_=2 && set -x
		
mkdir -p "$TRASH_DIRECTORY/prereq-test-dir-C_LOCALE_OUTPUT" &&
(
	cd "$TRASH_DIRECTORY/prereq-test-dir-C_LOCALE_OUTPUT" &&
	! test_bool_env GIT_TEST_GETTEXT_POISON false

)'
+ want_trace
+ test t '=' t
+ test t '=' t
+ trace_level_=2
+ set -x
+ mkdir -p '/home/jwalton/Build-Scripts/git-2.30.0/t/trash directory.t4129-apply-samemode/prereq-test-dir-C_LOCALE_OUTPUT'
+ cd '/home/jwalton/Build-Scripts/git-2.30.0/t/trash directory.t4129-apply-samemode/prereq-test-dir-C_LOCALE_OUTPUT'
+ test_bool_env GIT_TEST_GETTEXT_POISON false
+ test 2 '!=' 2
+ git env--helper '--type=bool' '--default=false' --exit-code GIT_TEST_GETTEXT_POISON
+ ret=1
+ return 1
+ test 0 '!=' 0
+ return 0
+ eval_ret=0
+ rm -rf '/home/jwalton/Build-Scripts/git-2.30.0/t/trash directory.t4129-apply-samemode/prereq-test-dir-C_LOCALE_OUTPUT'
+ test 0 '=' 0
+ say 'prerequisite C_LOCALE_OUTPUT ok'
+ say_color info 'prerequisite C_LOCALE_OUTPUT ok'
+ test -z info
+ shift
+ printf '%s\n' 'prerequisite C_LOCALE_OUTPUT ok'
prerequisite C_LOCALE_OUTPUT ok
+ return 0
+ test_set_prereq C_LOCALE_OUTPUT
+ test -n 
+ satisfied_prereq=' POSIXPERM BSLASHPSPEC EXECKEEPSPID COLUMNS_CAN_BE_1 PERL PTHREADS PYTHON PCRE LIBPCRE2 GETTEXT FILEMODE C_LOCALE_OUTPUT '
+ lazily_tested_prereq='FILEMODE C_LOCALE_OUTPUT '
+ total_prereq=1
+ satisfied_this_prereq=t
+ prerequisite='!C_LOCALE_OUTPUT'
+ test -z 
+ missing_prereq='!C_LOCALE_OUTPUT'
+ test 1 '=' 0
+ test 'x!' '=' 'xinvalid mode'
+ grep 'invalid mode' err
error: invalid mode on line 5: 
+ return 0
ok 8 - empty mode is rejected

expecting success of 4129.9 'bogus mode is rejected': 
	git reset --hard &&
	test_must_fail git apply patch-bogus-mode.txt 2>err &&
	test_i18ngrep "invalid mode" err

+ git reset --hard
HEAD is now at e950771 initial
+ test_must_fail git apply patch-bogus-mode.txt
+ _test_ok=
+ test_must_fail_acceptable git apply patch-bogus-mode.txt
+ test git '=' env
+ return 0
+ git apply patch-bogus-mode.txt
+ exit_code=128
+ test 128 -eq 0
+ test_match_signal 13 128
+ test 128 '=' 141
+ test 128 '=' 269
+ return 1
+ test 128 -gt 129
+ test 128 -eq 127
+ test 128 -eq 126
+ return 0
+ test_i18ngrep 'invalid mode' err
+ eval 'last_arg=${2}'
+ last_arg=err
+ test -f err
+ test 2 -lt 2
+ test 'x!' '=' 'xinvalid mode'
+ test_have_prereq '!C_LOCALE_OUTPUT'
+ save_IFS=' 	
'
+ IFS=,
+ set -- '!C_LOCALE_OUTPUT'
+ IFS=' 	
'
+ total_prereq=0
+ ok_prereq=0
+ missing_prereq=
+ negative_prereq=t
+ prerequisite=C_LOCALE_OUTPUT
+ total_prereq=1
+ satisfied_this_prereq=t
+ prerequisite='!C_LOCALE_OUTPUT'
+ test -z 
+ missing_prereq='!C_LOCALE_OUTPUT'
+ test 1 '=' 0
+ test 'x!' '=' 'xinvalid mode'
+ grep 'invalid mode' err
error: invalid mode on line 5: garbage
+ return 0
ok 9 - bogus mode is rejected

expecting success of 4129.10 'do not use core.sharedRepository for working tree files': 
	git reset --hard &&
	test_config core.sharedRepository 0666 &&
	(
		# Remove a default ACL if possible.
		(setfacl -k newdir 2>/dev/null || true) &&
		umask 0077 &&

		# Test both files (f1) and leading dirs (d)
		mkdir d &&
		touch f1 d/f2 &&
		git add f1 d/f2 &&
		git diff --staged >patch-f1-and-f2.txt &&

		rm -rf d f1 &&
		git apply patch-f1-and-f2.txt &&

		echo "-rw-------" >f1_mode.expected &&
		echo "drwx------" >d_mode.expected &&
		test_modebits f1 >f1_mode.actual &&
		test_modebits d >d_mode.actual &&
		test_cmp f1_mode.expected f1_mode.actual &&
		test_cmp d_mode.expected d_mode.actual
	)

+ git reset --hard
HEAD is now at e950771 initial
+ test_config core.sharedRepository 0666
+ config_dir=
+ test core.sharedRepository '=' -C
+ test_when_finished 'test_unconfig  '"'"'core.sharedRepository'"'"
+ test 0 '=' 0
+ test_cleanup='{ test_unconfig  '"'"'core.sharedRepository'"'"'
		} && (exit "$eval_ret"); eval_ret=$?; :'
+ git config core.sharedRepository 0666
+ setfacl -k newdir
+ true
+ umask 0077
+ mkdir d
+ touch f1 d/f2
+ git add f1 d/f2
+ git diff --staged
+ rm -rf d f1
+ git apply patch-f1-and-f2.txt
+ echo -rw-------
+ echo drwx------
+ test_modebits f1
+ + sed -els 's|^\(..........\).*|\1|' -ld
 f1
+ test_modebits d
+ ls+  -ld dsed
 -e 's|^\(..........\).*|\1|'
+ test_cmp f1_mode.expected f1_mode.actual
+ eval 'diff -u' '"$@"'
+ diff -u f1_mode.expected f1_mode.actual
+ test_cmp d_mode.expected d_mode.actual
+ eval 'diff -u' '"$@"'
+ diff -u d_mode.expected d_mode.actual
--- d_mode.expected
+++ d_mode.actual
@@ -1 +1 @@
-drwx------
+drwx--S---
error: last command exited with $?=1
not ok 10 - do not use core.sharedRepository for working tree files
#	
#		git reset --hard &&
#		test_config core.sharedRepository 0666 &&
#		(
#			# Remove a default ACL if possible.
#			(setfacl -k newdir 2>/dev/null || true) &&
#			umask 0077 &&
#	
#			# Test both files (f1) and leading dirs (d)
#			mkdir d &&
#			touch f1 d/f2 &&
#			git add f1 d/f2 &&
#			git diff --staged >patch-f1-and-f2.txt &&
#	
#			rm -rf d f1 &&
#			git apply patch-f1-and-f2.txt &&
#	
#			echo "-rw-------" >f1_mode.expected &&
#			echo "drwx------" >d_mode.expected &&
#			test_modebits f1 >f1_mode.actual &&
#			test_modebits d >d_mode.actual &&
#			test_cmp f1_mode.expected f1_mode.actual &&
#			test_cmp d_mode.expected d_mode.actual
#		)
#	

Re: Git 2.30.0 and failed self tests

[Matheus Tavares Bernardino]

On Sat, Jan 9, 2021 at 4:42 PM Jeffrey Walton <noloader@gmail.com> wrote:
>
> On Sat, Jan 9, 2021 at 7:44 AM Christian Couder
> <christian.couder@gmail.com> wrote:
> >
> > On Sat, Jan 9, 2021 at 12:33 PM Jeffrey Walton <noloader@gmail.com> wrote:
> >
> > > I'm seeing a failed self test with 2.30.0 on Alpine Linux 3.10,
> > > x86_64. Alpine Linux uses Musl and BusyBox, so things may be a bit
> > > sideways because of them.
> >
> > When a test script fails, could you try going into the "t" directory,
> > running the test script with -i -v -x and sending the output?
> >
> > > *** t4129-apply-samemode.sh ***
> >
> > For example you could run the above test script with:
> >
> > $ cd t
> > $ ./t4129-apply-samemode.sh -i -v -x
>
> Thanks Christian and Matheus,
>
> Attached is the redirected output of t4129.

Thanks for sending the output. Yeah, the problem is that the test
doesn't account for the presence of the setgid bit (which is inherited
from a parent dir). Here is the relevant part:

+ diff -u d_mode.expected d_mode.actual
--- d_mode.expected
+++ d_mode.actual
@@ -1 +1 @@
-drwx------
+drwx--S---
error: last command exited with $?=1

A patch fixing this issue was already sent, and it is marked to be
merged to next:
https://lore.kernel.org/git/b734425e3235651e738e6eac47eae0db7db92e7e.1609861567.git.matheus.bernardino@usp.br/

Re: Git 2.30.0 and failed self tests

[Jeffrey Walton]

On Sat, Jan 9, 2021 at 3:16 PM Matheus Tavares Bernardino
<matheus.bernardino@usp.br> wrote:
> On Sat, Jan 9, 2021 at 4:42 PM Jeffrey Walton <noloader@gmail.com> wrote:
> > On Sat, Jan 9, 2021 at 7:44 AM Christian Couder
> > ...
> > Thanks Christian and Matheus,
> >
> > Attached is the redirected output of t4129.
>
> Thanks for sending the output. Yeah, the problem is that the test
> doesn't account for the presence of the setgid bit (which is inherited
> from a parent dir). Here is the relevant part:
>
> + diff -u d_mode.expected d_mode.actual
> --- d_mode.expected
> +++ d_mode.actual
> @@ -1 +1 @@
> -drwx------
> +drwx--S---
> error: last command exited with $?=1
>
> A patch fixing this issue was already sent, and it is marked to be
> merged to next:
> https://lore.kernel.org/git/b734425e3235651e738e6eac47eae0db7db92e7e.1609861567.git.matheus.bernardino@usp.br/

Perfect, thanks. It tested OK.

Jeff

Re: Git 2.30.0 and failed self tests

[Junio C Hamano]

Jeffrey Walton <noloader@gmail.com> writes:

> I'm seeing a failed self test with 2.30.0 on Alpine Linux 3.10,
> x86_64. Alpine Linux uses Musl and BusyBox, so things may be a bit
> sideways because of them.
>
> *** t4129-apply-samemode.sh ***
> ok 1 - setup
> ...

I thought that Alpine with Musl is part of our automated tests.
Let's see if we had any test failures there.

  https://github.com/git/git/runs/1618243621?check_suite_focus=true

It seems that we didn't notice anything strange while running t4129
there.

  https://github.com/git/git/runs/1618243621?check_suite_focus=true#step:5:1080

Note that it seems that GitHub gives the full output only to logged
in users.

Re: Git 2.30.0 and failed self tests

[Stefan Moch]

Hi Jeff,

Jeffrey Walton wrote:
> I'm seeing some failed self tests with 2.30.0 on Fedora 33 x86_64
> fully patched. They seem to be centered around email.

I cannot confirm this on the same git version and platform:

    # passed all 174 test(s)
    1..174

Christian's suggestion from your other thread about running the test
with the options -i -v -x should also help here to give more
detailed error messages:

https://lore.kernel.org/git/CAP8UFD30et-kL8dFoWvh7aPf4AKbzGxSzTuA=B3YNHZL_1axFA@mail.gmail.com/

>     *** t9001-send-email.sh ***
>     ok 1 - prepare reference tree
>     ok 2 - Setup helper tool
>     ok 3 - Extract patches
>     not ok 4 - No confirm with --suppress-cc


Since the tests 1-3 do not call git send-email, but test 4 and most
of the following do, I suspect the system is missing some dependency
packages needed for git send-email, probably mail-related Perl modules.

Installing Fedora's git-email package is probably enough to fix this:

    dnf install git-email



Stefan

Re: Git 2.30.0 and failed self tests

[Jeffrey Walton]

On Sun, Jan 10, 2021 at 12:09 PM Stefan Moch <stefanmoch@mail.de> wrote:
>
> Hi Jeff,
>
> Jeffrey Walton wrote:
> > I'm seeing some failed self tests with 2.30.0 on Fedora 33 x86_64
> > fully patched. They seem to be centered around email.
>
> I cannot confirm this on the same git version and platform:
>
>     # passed all 174 test(s)
>     1..174
>
> Christian's suggestion from your other thread about running the test
> with the options -i -v -x should also help here to give more
> detailed error messages:
>
> https://lore.kernel.org/git/CAP8UFD30et-kL8dFoWvh7aPf4AKbzGxSzTuA=B3YNHZL_1axFA@mail.gmail.com/
>
> >     *** t9001-send-email.sh ***
> >     ok 1 - prepare reference tree
> >     ok 2 - Setup helper tool
> >     ok 3 - Extract patches
> >     not ok 4 - No confirm with --suppress-cc
>
>
> Since the tests 1-3 do not call git send-email, but test 4 and most
> of the following do, I suspect the system is missing some dependency
> packages needed for git send-email, probably mail-related Perl modules.
>
> Installing Fedora's git-email package is probably enough to fix this:
>
>     dnf install git-email

Yeah, I think I yanked exim out of this machine a long time ago (or
whatever smtp mailer gets installed). It faces the internet and I did
not want the additional attack surface.

Let me run that test manually.

Jeff

Re: Git 2.30.0 and failed self tests

[Jeffrey Walton]

On Sun, Jan 10, 2021 at 12:09 PM Stefan Moch <stefanmoch@mail.de> wrote:
>
> Jeffrey Walton wrote:
> > I'm seeing some failed self tests with 2.30.0 on Fedora 33 x86_64
> > fully patched. They seem to be centered around email.
>
> I cannot confirm this on the same git version and platform:
>
>     # passed all 174 test(s)
>     1..174
>
> Christian's suggestion from your other thread about running the test
> with the options -i -v -x should also help here to give more
> detailed error messages:
>
> https://lore.kernel.org/git/CAP8UFD30et-kL8dFoWvh7aPf4AKbzGxSzTuA=B3YNHZL_1axFA@mail.gmail.com/
>
> >     *** t9001-send-email.sh ***
> >     ok 1 - prepare reference tree
> >     ok 2 - Setup helper tool
> >     ok 3 - Extract patches
> >     not ok 4 - No confirm with --suppress-cc
>
> Since the tests 1-3 do not call git send-email, but test 4 and most
> of the following do, I suspect the system is missing some dependency
> packages needed for git send-email, probably mail-related Perl modules.
>
> Installing Fedora's git-email package is probably enough to fix this:
>
>     dnf install git-email

It looks like a Perl problem.

I've got a Perl recipe for OpenSSL. The OpenSSL devs don't realize the
trouble they create with that dependency. Old systems need a newer
Perl for OpenSSL. The F33 machine is a test machine, so Perl gets
tested on it, too.

t$ ./t9001-send-email.sh -i -v -x
Initialized empty Git repository in
/home/jwalton/Build-Scripts/git-2.30.0/t/trash
directory.t9001-send-email/.git/
expecting success of 9001.1 'prepare reference tree':
    echo "1A quick brown fox jumps over the" >file &&
    echo "lazy dog" >>file &&
    git add file &&
    GIT_AUTHOR_NAME="A" git commit -a -m "Initial."

++ echo '1A quick brown fox jumps over the'
++ echo 'lazy dog'
++ git add file
++ GIT_AUTHOR_NAME=A
++ git commit -a -m Initial.
[master (root-commit) fbff2ba] Initial.
 Author: A <author@example.com>
 1 file changed, 2 insertions(+)
 create mode 100644 file
ok 1 - prepare reference tree

expecting success of 9001.2 'Setup helper tool':
    write_script fake.sendmail <<-\EOF &&
    shift
    output=1
    while test -f commandline$output
    do
        output=$(($output+1))
    done
    for a
    do
        echo "!$a!"
    done >commandline$output
    cat >"msgtxt$output"
    EOF
    git add fake.sendmail &&
    GIT_AUTHOR_NAME="A" git commit -a -m "Second."

++ write_script fake.sendmail
++ echo '#!/bin/sh'
++ cat
++ chmod +x fake.sendmail
++ git add fake.sendmail
++ GIT_AUTHOR_NAME=A
++ git commit -a -m Second.
[master 60cacbf] Second.
 Author: A <author@example.com>
 1 file changed, 12 insertions(+)
 create mode 100755 fake.sendmail
ok 2 - Setup helper tool

expecting success of 9001.3 'Extract patches':
    patches=$(git format-patch -s --cc="One <one@example.com>"
--cc=two@example.com -n HEAD^1) &&
    threaded_patches=$(git format-patch -o threaded -s
--in-reply-to="format" HEAD^1)

+++ git format-patch -s '--cc=One <one@example.com>'
--cc=two@example.com -n 'HEAD^1'
++ patches=0001-Second.patch
+++ git format-patch -o threaded -s --in-reply-to=format 'HEAD^1'
++ threaded_patches=threaded/0001-Second.patch
ok 3 - Extract patches

expecting success of 9001.4 'No confirm with --suppress-cc':
    test_no_confirm --suppress-cc=sob &&
    check_no_confirm

++ test_no_confirm --suppress-cc=sob
++ rm -f no_confirm_okay
++ echo n
+++ pwd
++ GIT_SEND_EMAIL_NOTTY=1
++ git send-email '--from=Example <from@example.com>'
--to=nobody@example.com
'--smtp-server=/home/jwalton/Build-Scripts/git-2.30.0/t/trash
directory.t9001-send-email/fake.sendmail' --suppress-cc=sob
0001-Second.patch
Can't locate Term/ReadLine.pm in @INC (you may need to install the
Term::ReadLine module) (@INC contains:
/home/jwalton/Build-Scripts/git-2.30.0/perl/build/lib
/home/jwalton/Build-Scripts/git-2.30.0/t/../perl/build/lib
/usr/local/lib64/perl5/5.32 /usr/local/share/perl5/5.32
/usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl
/usr/lib64/perl5 /usr/share/perl5) at
/home/jwalton/Build-Scripts/git-2.30.0/git-send-email line 25.
BEGIN failed--compilation aborted at
/home/jwalton/Build-Scripts/git-2.30.0/git-send-email line 25.
error: last command exited with $?=2
not ok 4 - No confirm with --suppress-cc
#
#        test_no_confirm --suppress-cc=sob &&
#        check_no_confirm

Jeff

Re: Git 2.30.0 and failed self tests

[Jeffrey Walton]

On Sun, Jan 10, 2021 at 12:09 PM Stefan Moch <stefanmoch@mail.de> wrote:
>
> Jeffrey Walton wrote:
> > I'm seeing some failed self tests with 2.30.0 on Fedora 33 x86_64
> > fully patched. They seem to be centered around email.
>
> I cannot confirm this on the same git version and platform:
>
>     # passed all 174 test(s)
>     1..174
>
> Christian's suggestion from your other thread about running the test
> with the options -i -v -x should also help here to give more
> detailed error messages:
>
> https://lore.kernel.org/git/CAP8UFD30et-kL8dFoWvh7aPf4AKbzGxSzTuA=B3YNHZL_1axFA@mail.gmail.com/
>
> >     *** t9001-send-email.sh ***
> >     ok 1 - prepare reference tree
> >     ok 2 - Setup helper tool
> >     ok 3 - Extract patches
> >     not ok 4 - No confirm with --suppress-cc
>
> Since the tests 1-3 do not call git send-email, but test 4 and most
> of the following do, I suspect the system is missing some dependency
> packages needed for git send-email, probably mail-related Perl modules.
>
> Installing Fedora's git-email package is probably enough to fix this:
>
>     dnf install git-email

I deleted my copy of Perl. I am only using the system's version:

    $ command -v perl
    /bin/perl

    $ perl --version
    This is perl 5, version 32, subversion 0 (v5.32.0) built for
x86_64-linux-thread-multi
    (with 44 registered patches, see perl -V for more detail)

I'm still seeing the failure. Weird...

Jeff