From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 167291F4B4 for ; Tue, 20 Apr 2021 19:34:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233660AbhDTTel (ORCPT ); Tue, 20 Apr 2021 15:34:41 -0400 Received: from pb-smtp2.pobox.com ([64.147.108.71]:61095 "EHLO pb-smtp2.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233544AbhDTTel (ORCPT ); Tue, 20 Apr 2021 15:34:41 -0400 Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id AFE4DB8B73; Tue, 20 Apr 2021 15:34:08 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=XqKha+K/e78rgJ37ZstS/jiuY/g=; b=dYeFip nagJw/mawoQFO5EAcE0p7oixQphlyoA8tGphDKDSutFa++msGP+GZOoKewsnyWY3 xOmzVzw80gAzcK+n14oppL3Wb7q4ugJ7R1RDstYXKJizSGX+FsfYbS+SJksL9iuV +MNxVGIjhKhTyd8UdgdId8DFnh5F+eJ3NVRa8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=YEqsXRE228iFFa5BsCS4wgX+Y61LUOUp RkGl+taGuHtVHiJBHwtZsdBImaun5gvs8Bhc4b+4Ns6lyIgHYiCq0dTSZCRW0UOf 8KNxTRhCTJSOOjIL6CoLtEVCSPl+5H4Nn/UCTgUQvrfmYBfUJZS1RVwTMlZ0X84Q WMmuWARuLr4= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id A7722B8B71; Tue, 20 Apr 2021 15:34:08 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.74.119.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id 27B98B8B70; Tue, 20 Apr 2021 15:34:08 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: "Han-Wen Nienhuys via GitGitGadget" Cc: git@vger.kernel.org, Han-Wen Nienhuys , Jeff King , Ramsay Jones , Jonathan Nieder , Johannes Schindelin , Jonathan Tan , Josh Steadmon , Emily Shaffer , Patrick Steinhardt , =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason , Felipe Contreras , Derrick Stolee , Han-Wen Nienhuys Subject: Re: [PATCH v7 02/28] refs: document reflog_expire_fn's flag argument References: <554bb1ac3aed066eb578a305b7fe76f1660f6153.1618832277.git.gitgitgadget@gmail.com> Date: Tue, 20 Apr 2021 12:34:07 -0700 In-Reply-To: <554bb1ac3aed066eb578a305b7fe76f1660f6153.1618832277.git.gitgitgadget@gmail.com> (Han-Wen Nienhuys via GitGitGadget's message of "Mon, 19 Apr 2021 11:37:30 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 5FE2DFDA-A20F-11EB-A657-74DE23BA3BAF-77302942!pb-smtp2.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org "Han-Wen Nienhuys via GitGitGadget" writes: > From: Han-Wen Nienhuys > > Signed-off-by: Han-Wen Nienhuys > --- > refs/refs-internal.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/refs/refs-internal.h b/refs/refs-internal.h > index 546a6b965dcc..a31c1f465beb 100644 > --- a/refs/refs-internal.h > +++ b/refs/refs-internal.h > @@ -592,6 +592,10 @@ typedef int reflog_exists_fn(struct ref_store *ref_store, const char *refname); > typedef int create_reflog_fn(struct ref_store *ref_store, const char *refname, > int force_create, struct strbuf *err); > typedef int delete_reflog_fn(struct ref_store *ref_store, const char *refname); > + > +/* > + * `flags` accepts a bitmask of `expire_reflog_flags`. > + */ OK. It would have been better to say what expire_reflog_flags is (i.e. `enum expire_reflog_flags`), though. > typedef int reflog_expire_fn(struct ref_store *ref_store, > const char *refname, const struct object_id *oid, > unsigned int flags,