list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <>
To: Eric Sunshine <>
Cc: "Alex Henrie" <>,
	"Git List" <>,
	"Nguyễn Thái Ngọc Duy" <>
Subject: Re: [PATCH] graph: improve grammar of "invalid color" error message
Date: Mon, 10 May 2021 15:10:45 +0900	[thread overview]
Message-ID: <xmqqy2cnqftm.fsf@gitster.g> (raw)
In-Reply-To: <> (Eric Sunshine's message of "Sun, 9 May 2021 18:02:51 -0400")

Eric Sunshine <> writes:

> On Sun, May 9, 2021 at 5:23 PM Alex Henrie <> wrote:
>> Without the "d", it sounds like a command, not an error, and is liable
>> to be translated incorrectly.
>> Signed-off-by: Alex Henrie <>
>> ---
>> diff --git a/graph.c b/graph.c
>> @@ -95,7 +95,7 @@ static void parse_graph_colors_config(struct strvec *colors, const char *string)
>> -                       warning(_("ignore invalid color '%.*s' in log.graphColors"),
>> +                       warning(_("ignored invalid color '%.*s' in log.graphColors"),
> Another possibility: "ignoring invalid color ... in ..."
> Even better: "invalid color ... in ..."

The last one, if it does not say what we did to that invalid thing,
is not as helpful as Alex's or your "another possibility".

Betweein "ignored" vs "ignoring", I do not have a preference, but
whichever one is more prevalent in our existing messages should be
used, I would think.


      parent reply	other threads:[~2021-05-10  6:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-09 21:22 Alex Henrie
2021-05-09 22:02 ` Eric Sunshine
2021-05-09 23:06   ` Alex Henrie
2021-05-10  6:10   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqy2cnqftm.fsf@gitster.g \ \ \ \ \ \
    --subject='Re: [PATCH] graph: improve grammar of "invalid color" error message' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).