From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Ramsay Jones <ramsay@ramsayjones.plus.com>,
Denton Liu <liu.denton@gmail.com>, Jeff King <peff@peff.net>
Subject: Re: [PATCH v4] Makefile: add a non-.PHONY "sparse-incr" target
Date: Tue, 28 Sep 2021 10:44:38 -0700 [thread overview]
Message-ID: <xmqqy27gk321.fsf@gitster.g> (raw)
In-Reply-To: <patch-v4-1.1-f31fa3e8282-20210928T014023Z-avarab@gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Tue, 28 Sep 2021 03:43:31 +0200")
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> I.e. per [2] want "make <file>.sp" to *always* run "sparse", even
> though a corresponding "make <file>.o" would only re-run the "real"
> compilation if needed.
It is different from my reading. If <file>.c and what it includes
haven't changed, it would be fine not to run "sparse". The point of
running "make <file>.sp" is to see it fail if there is something
problematic. If there is any room for the word "*always*" to come
into the observation, it would be more like "if we cannot make it
follow the usual dependency rules like the real compilation, we can
live with it always running, as it is fast enough". If we can make
it honor the dependencies, that would give the best of both worlds,
and we do not have to add an extra target.
next prev parent reply other threads:[~2021-09-28 17:44 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-21 22:55 [PATCH 0/3] Makefile: make "sparse" and "hdr-check" non-.PHONY Ævar Arnfjörð Bjarmason
2021-09-21 22:55 ` [PATCH 1/3] Makefile: make the "sparse" target non-.PHONY Ævar Arnfjörð Bjarmason
2021-09-22 2:24 ` Jeff King
2021-09-21 22:55 ` [PATCH 2/3] Makefile: do one append in %.hcc rule Ævar Arnfjörð Bjarmason
2021-09-21 22:55 ` [PATCH 3/3] Makefile: make the "hdr-check" target non-.PHONY Ævar Arnfjörð Bjarmason
2021-09-22 2:11 ` [PATCH 0/3] Makefile: make "sparse" and "hdr-check" non-.PHONY Jeff King
2021-09-22 16:58 ` Ramsay Jones
2021-09-22 17:53 ` Jeff King
2021-09-22 19:17 ` Ramsay Jones
2021-09-22 23:28 ` Junio C Hamano
2021-09-23 1:07 ` Ævar Arnfjörð Bjarmason
2021-09-23 1:23 ` Junio C Hamano
2021-09-23 2:17 ` Ævar Arnfjörð Bjarmason
2021-09-22 19:24 ` Junio C Hamano
2021-09-23 0:07 ` [PATCH v2] Makefile: make the "sparse" target non-.PHONY Ævar Arnfjörð Bjarmason
2021-09-23 16:24 ` Jeff King
2021-09-23 17:06 ` Ævar Arnfjörð Bjarmason
2021-09-23 17:17 ` Jeff King
2021-09-23 17:39 ` Junio C Hamano
2021-09-23 23:28 ` Ramsay Jones
2021-09-24 1:16 ` Ævar Arnfjörð Bjarmason
2021-09-24 16:38 ` Ramsay Jones
2021-09-24 1:30 ` Ævar Arnfjörð Bjarmason
2021-09-24 19:37 ` Junio C Hamano
2021-09-28 1:15 ` [PATCH v3] Makefile: add a non-.PHONY "sparse-incr" target Ævar Arnfjörð Bjarmason
2021-09-28 1:43 ` [PATCH v4] " Ævar Arnfjörð Bjarmason
2021-09-28 17:44 ` Junio C Hamano [this message]
2021-09-28 19:45 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy27gk321.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=liu.denton@gmail.com \
--cc=peff@peff.net \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).