From: Junio C Hamano <gitster@pobox.com>
To: Johannes Altmanninger <aclopte@gmail.com>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
git@vger.kernel.org, "SZEDER Gábor" <szeder.dev@gmail.com>,
"René Scharfe" <l.s.r@web.de>
Subject: Re: [PATCH v7 4/7] progress.c tests: test some invalid usage
Date: Mon, 03 Jan 2022 15:48:00 -0800 [thread overview]
Message-ID: <xmqqy23wgz4f.fsf@gitster.g> (raw)
In-Reply-To: <20211227011100.g3pwc67onlc7qs7t@gmail.com> (Johannes Altmanninger's message of "Mon, 27 Dec 2021 02:11:00 +0100")
Johannes Altmanninger <aclopte@gmail.com> writes:
>> + grep region_enter.*progress trace-start.event &&
>> + ! grep region_leave.*progress trace-start.event
>
> should "!" be "test_must_fail"? Same below.
The answer is no. The main difference between test_must_fail and
"!" is that the former is designed to catch ungraceful death (e.g.
by segfault) and to be used to expect controlled failure from OUR
programs (i.e. "git" and "test-tool" invocations). We are not in
the business of catching segfaulting bug in system's "grep", so it
is perfectly fine to use "!" here.
next prev parent reply other threads:[~2022-01-03 23:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 4:24 [PATCH v7 0/7] progress: test fixes / cleanup Ævar Arnfjörð Bjarmason
2021-12-17 4:24 ` [PATCH v7 1/7] leak tests: fix a memory leaks in "test-progress" helper Ævar Arnfjörð Bjarmason
2021-12-27 1:07 ` Johannes Altmanninger
2021-12-17 4:24 ` [PATCH v7 2/7] progress.c test helper: add missing braces Ævar Arnfjörð Bjarmason
2021-12-17 4:24 ` [PATCH v7 3/7] progress.c tests: make start/stop commands on stdin Ævar Arnfjörð Bjarmason
2021-12-27 1:10 ` Johannes Altmanninger
2021-12-27 1:31 ` Ævar Arnfjörð Bjarmason
2021-12-17 4:24 ` [PATCH v7 4/7] progress.c tests: test some invalid usage Ævar Arnfjörð Bjarmason
2021-12-27 1:11 ` Johannes Altmanninger
2022-01-03 23:48 ` Junio C Hamano [this message]
2021-12-17 4:25 ` [PATCH v7 5/7] progress.c: add temporary variable from progress struct Ævar Arnfjörð Bjarmason
2021-12-27 1:11 ` Johannes Altmanninger
2021-12-17 4:25 ` [PATCH v7 6/7] pack-bitmap-write.c: don't return without stop_progress() Ævar Arnfjörð Bjarmason
2021-12-27 1:11 ` Johannes Altmanninger
2021-12-17 4:25 ` [PATCH v7 7/7] various *.c: use isatty(0|2), not isatty(STDIN_FILENO|STDERR_FILENO) Ævar Arnfjörð Bjarmason
2021-12-27 1:17 ` Johannes Altmanninger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy23wgz4f.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=aclopte@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).