From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 725EE1F54E for ; Mon, 15 Aug 2022 04:22:20 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=pobox.com header.i=@pobox.com header.b="a5jdkGVb"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240369AbiHOEWS (ORCPT ); Mon, 15 Aug 2022 00:22:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230237AbiHOEWR (ORCPT ); Mon, 15 Aug 2022 00:22:17 -0400 Received: from pb-smtp1.pobox.com (pb-smtp1.pobox.com [64.147.108.70]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 227BE140FC for ; Sun, 14 Aug 2022 21:22:16 -0700 (PDT) Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id C4C9814DA14; Mon, 15 Aug 2022 00:22:14 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:message-id:mime-version:content-type; s=sasl; bh=ozJ2GyMHiYiDFB2THWN1fFqUvi/nenaV9xraFaxMio8=; b=a5jd kGVbZ24pNCoiFfnjVFK7o0IyLrGxVfF19W9Pr6b8QQHIYj55p3tU5fS/sy4PXGtP E6BAzIJ9Olk9a1fntya0+jUY2HQABTR31cgtP3ItbL1fXuL910xt7NLIKrA8U4ZK qmsB2piVMjNgcRNyhVWhCLKCOR/5wJnJWyPs1UE= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id BC16814DA13; Mon, 15 Aug 2022 00:22:14 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.83.5.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id EE92814DA11; Mon, 15 Aug 2022 00:22:13 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: Justin Donnelly Cc: Justin Donnelly via GitGitGadget , git@vger.kernel.org, =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason , newren@gmail.com, phillip.wood@dunelm.org.uk, Johannes.Schindelin@gmx.de Subject: Re: [PATCH v2] git-prompt: show presence of unresolved conflicts at command prompt References: Date: Sun, 14 Aug 2022 21:22:12 -0700 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: D6CB66F4-1C51-11ED-A7C9-5E84C8D8090B-77302942!pb-smtp1.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Justin Donnelly writes: > I hope this is against protocol/etiquette, but after some initial > feedback from Junio, I haven't gotten any more. I wasn't sure if > nobody had seen the patch, or if there just wasn't any interest. It probably is a bit of both. I personally did not see much point in adding the long "conflicts" marker to the shell prompt (I did worry about possible complaints by end users triggered by seeing them suddenly without asking, which was why I commented on the patch) and I was waiting for interested folks to speak out. I do not know about other folks if they did see and did not find it interesting, they are not looking at others' work, or your second round came on a particularly bad day (busy with other topics, or weekend just before the list was swamped with many new topics at the beginning of a new week, or something). Pinging on the thread like you did would be the right thing to do to "kick" those, who did see and who were in favor but who kept silent, into action ;-)