git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Josh Steadmon <steadmon@google.com>
Cc: git@vger.kernel.org,  delmerico@google.com
Subject: Re: sd/negotiate-trace-fix
Date: Tue, 23 Jan 2024 13:34:58 -0800	[thread overview]
Message-ID: <xmqqy1cflon1.fsf@gitster.g> (raw)
In-Reply-To: <ZbAu49xkxEzJ3ZkX@google.com> (Josh Steadmon's message of "Tue, 23 Jan 2024 13:25:55 -0800")

Josh Steadmon <steadmon@google.com> writes:

> On 2024.01.19 17:56, Junio C Hamano wrote:
> [snip]
>> * sd/negotiate-trace-fix (2024-01-03) 1 commit
>>  - push: region_leave trace for negotiate_using_fetch
>> 
>>  Tracing fix.
>> 
>>  Waiting for a review response.
>>  cf. <xmqqbka27zu9.fsf@gitster.g>
>>  source: <20240103224054.1940209-1-delmerico@google.com>
>
> Hi Junio,
>
> Were there other open questions you had on this series? It looks like
> Sam answered all the questions in your xmqqbka27zu9.fsf@gitster.g reply.

Thanks for a reminder.

> In your other followup you mentioned running CI with tracing enabled for
> all tests. This is something that we suggested before [1] but it was
> pretty thoroughly rejected for runtime reasons. Perhaps a more efficient
> check for region_enter/leave pairs could be an option, though.

Yeah, perhaps.  It does not sound like an issue that must block this
patch in either case.

Thanks.


      reply	other threads:[~2024-01-23 21:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-20  1:56 What's cooking in git.git (Jan 2024, #06; Fri, 19) Junio C Hamano
2024-01-20  2:10 ` Ghanshyam Thakkar
2024-01-20 17:19   ` Junio C Hamano
2024-01-23  8:23 ` ps/reftable-optimize-io (was: What's cooking in git.git (Jan 2024, #06; Fri, 19)) Patrick Steinhardt
2024-01-23 21:25 ` sd/negotiate-trace-fix " Josh Steadmon
2024-01-23 21:34   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqy1cflon1.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=delmerico@google.com \
    --cc=git@vger.kernel.org \
    --cc=steadmon@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).