From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (May 2024, #02; Fri, 3)
Date: Mon, 06 May 2024 15:17:35 -0700 [thread overview]
Message-ID: <xmqqy18mwpog.fsf@gitster.g> (raw)
In-Reply-To: <ZjihN01c8gWX0s9H@tanuki> (Patrick Steinhardt's message of "Mon, 6 May 2024 11:21:59 +0200")
Patrick Steinhardt <ps@pks.im> writes:
> I have just sent out a new version [1] that fixes a few commit messages.
> Other than that I think this version should be ready to go.
>
> [1]: https://lore.kernel.org/git/cover.1714982328.git.ps@pks.im/T/#u
Thanks.
>> * ps/undecided-is-not-necessarily-sha1 (2024-04-30) 13 commits
>> . repository: stop setting SHA1 as the default object hash
>> . oss-fuzz/commit-graph: set up hash algorithm
>> . builtin/shortlog: don't set up revisions without repo
>> . builtin/diff: explicitly set hash algo when there is no repo
>> . builtin/bundle: abort "verify" early when there is no repository
>> . builtin/blame: don't access potentially unitialized `the_hash_algo`
>> . builtin/rev-parse: allow shortening to more than 40 hex characters
>> . remote-curl: fix parsing of detached SHA256 heads
>> . attr: fix BUG() when parsing attrs outside of repo
>> . attr: don't recompute default attribute source
>> . parse-options-cb: only abbreviate hashes when hash algo is known
>> . path: move `validate_headref()` to its only user
>> . path: harden validation of HEAD with non-standard hashes
>>
>> Before discovering the repository details, We used to assume SHA-1
>> as the "default" hash function, which has been corrected. Hopefully
>> this will smoke out codepaths that rely on such an unwarranted
>> assumptions.
>>
>> Seems to break t0003 with a NULL the_repository.
>>
>> Ejected out of 'seen' for now.
>> source: <cover.1714371422.git.ps@pks.im>
>
> Interesting, I couldn't reproduce this issue when rebasing the patches
> onto "seen". There were merge conflicts though, both with
> jc/no-default-attr-tree-in-bare and ps/the-index-is-no-more. So maybe
> there was a mismerge involved somewhere?
That is very possible.
next prev parent reply other threads:[~2024-05-06 22:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-04 0:27 What's cooking in git.git (May 2024, #02; Fri, 3) Junio C Hamano
2024-05-04 2:59 ` Dragan Simic
2024-05-04 8:58 ` ds/scalar-reconfigure-all-fix, was " Johannes Schindelin
2024-05-06 9:21 ` Patrick Steinhardt
2024-05-06 22:17 ` Junio C Hamano [this message]
2024-05-07 6:05 ` Junio C Hamano
2024-05-07 6:15 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy18mwpog.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).