From: Junio C Hamano <gitster@pobox.com>
To: "Torsten Bögershausen" <tboegi@web.de>
Cc: Reuben Hawkins <reubenhwk@gmail.com>,
git@vger.kernel.org, Dmitry Potapov <dpotapov@gmail.com>,
Joshua Jensen <jjensen@workspacewhiz.com>
Subject: Re: [PATCH] fast-import.c: always honor the filename case
Date: Mon, 03 Feb 2014 16:14:14 -0800 [thread overview]
Message-ID: <xmqqwqhbag4p.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <52EFFA36.8090305@web.de> ("Torsten Bögershausen"'s message of "Mon, 03 Feb 2014 21:21:10 +0100")
Torsten Bögershausen <tboegi@web.de> writes:
> []
>> So to summarize, when fast-import uses strncmp_icase (what fast-import does now) import on a repository where ignorecase=true is wrong. My patch, "fast-import.c: always honor the filename case" fixes this. Can you verify?
>>
>> Thanks in advance,
>> Reuben
>>
> Yes, I can verify. My feeling is that
> a) the fast-export should generate the rename the other way around.
> Would that be feasable ?
> Or generate a real rename ?
> (I'm not using fast-export or import myself)
I do not think this matters. Or at least, it should not matter. As
Peff said in the nearby message, core.ignorecase is completely about
the _filesystem_, and that git should generally be case-sensitive
internally.
And fast-import is about reading internal representation of paths
and data to populate the repository, without having to guess what
pathnames were meant to be used---the guess is only needed if we
need to consult the filesystem that loses case information.
The change made by 50906e04 (Support case folding in git fast-import
when core.ignorecase=true, 2010-10-03) should probably be half
reverted by making the case-squashing an optional feature, that
could be used even on a system with case sensitive filesystems.
next prev parent reply other threads:[~2014-02-04 0:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-02 13:13 [PATCH] fast-import.c: always honor the filename case Reuben Hawkins
2014-02-02 20:08 ` Torsten Bögershausen
[not found] ` <CAD_8n+RZACW0380co75gWSwVmCJdcH4COsySTF3BFCyKEumXNA@mail.gmail.com>
2014-02-03 20:21 ` Torsten Bögershausen
2014-02-04 0:14 ` Junio C Hamano [this message]
[not found] ` <CAD_8n+RuwQEXJRCOr+B_PqA7z6LkFdbcRZkiiVJsEhJ=+YjRDg@mail.gmail.com>
2014-02-05 21:19 ` Torsten Bögershausen
[not found] ` <CAD_8n+Thn3tNTYxLK49mDOGdLpWRCFUCJo9b76UbAjnCdqXsRQ@mail.gmail.com>
2014-02-09 20:34 ` Torsten Bögershausen
[not found] ` <CAD_8n+ToUDbXrVuru7GV7toYKHXuQb8vL3B_-sfzQdXZFqzD2A@mail.gmail.com>
2014-02-11 17:29 ` Torsten Bögershausen
2014-02-02 23:00 ` Jeff King
2014-02-03 17:21 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwqhbag4p.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=dpotapov@gmail.com \
--cc=git@vger.kernel.org \
--cc=jjensen@workspacewhiz.com \
--cc=reubenhwk@gmail.com \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).