git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Ronald Wampler <rdwampler@gmail.com>
Cc: git@vger.kernel.org, mackyle@gmail.com, reubenhwk@gmail.com,
	sunshine@sunshineco.com
Subject: Re: [PATCH] Makefile: add NEEDS_LIBRT to optionally link with librt
Date: Thu, 07 Jul 2016 14:14:49 -0700	[thread overview]
Message-ID: <xmqqwpkxnoae.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20160707204554.14961-1-rdwampler@gmail.com> (Ronald Wampler's message of "Thu, 7 Jul 2016 16:45:54 -0400")

Ronald Wampler <rdwampler@gmail.com> writes:

> I am not sure if this the correction solution. Another option I
> considered was to wrap the EXTLIBS += -lrt is an ifndef NO_RT and only
> defining NO_RT for Mac OS X in config.mak.uname.

That alternative would make the resulting code noisier/uglier with
nested ifdef, I would imagine, but it would be of less impact to the
existing users.  But my gut feeling is that the patch you sent is
probably a better solution for the longer term.

Thanks.


  reply	other threads:[~2016-07-07 21:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-07 20:45 [PATCH] Makefile: add NEEDS_LIBRT to optionally link with librt Ronald Wampler
2016-07-07 21:14 ` Junio C Hamano [this message]
2016-07-10 22:16   ` [PATCH] config.mak.uname: define NEEDS_LIBRT under Linux, for now Eric Wong
2016-07-11 10:36     ` brian m. carlson
2016-07-11 18:44       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqwpkxnoae.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=mackyle@gmail.com \
    --cc=rdwampler@gmail.com \
    --cc=reubenhwk@gmail.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).