From: Junio C Hamano <gitster@pobox.com>
To: Olga Telezhnaya <olyatelezhnaya@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2 1/6] ref-filter: add objectsize:disk option
Date: Wed, 26 Dec 2018 12:44:07 -0800 [thread overview]
Message-ID: <xmqqwontmmuv.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: 01020167e063687c-37a43a09-0a5f-4335-8c21-ec15a0a67882-000000@eu-west-1.amazonses.com
Olga Telezhnaya <olyatelezhnaya@gmail.com> writes:
> @@ -880,7 +886,10 @@ static void grab_common_values(struct atom_value *val, int deref, struct expand_
> name++;
> if (!strcmp(name, "objecttype"))
> v->s = xstrdup(type_name(oi->type));
> - else if (!strcmp(name, "objectsize")) {
> + else if (!strcmp(name, "objectsize:disk")) {
> + v->value = oi->disk_size;
> + v->s = xstrfmt("%"PRIuMAX, (intmax_t)oi->disk_size);
Shouldn't this cast the field to (uintmax_t) type, as we'd format
with %PRIuMAX and we know the size on-disk is not negative?
Other than that, looks good.
Let me rewind the tip of 'next' and replace the previous round with
this iteration.
Thanks.
> + } else if (!strcmp(name, "objectsize")) {
> v->value = oi->size;
> v->s = xstrfmt("%"PRIuMAX , (uintmax_t)oi->size);
> }
>
> --
> https://github.com/git/git/pull/552
next prev parent reply other threads:[~2018-12-28 20:13 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-09 7:37 [RFC PATCH 0/5] ref-filter: add new formatting options Оля Тележная
2018-11-09 7:44 ` [RFC PATCH 1/5] ref-filter: add objectsize:disk option Olga Telezhnaya
2018-11-09 7:44 ` [RFC PATCH 3/5] ref-filter: add deltabase option Olga Telezhnaya
2018-11-09 7:44 ` [RFC PATCH 5/5] ref-filter: add docs for new options Olga Telezhnaya
2018-11-12 5:24 ` Junio C Hamano
2018-11-09 7:44 ` [RFC PATCH 2/5] ref-filter: add tests for objectsize:disk Olga Telezhnaya
2018-11-09 7:44 ` [RFC PATCH 4/5] ref-filter: add tests for deltabase Olga Telezhnaya
2018-11-12 5:03 ` [RFC PATCH 1/5] ref-filter: add objectsize:disk option Junio C Hamano
2018-11-12 12:03 ` Johannes Schindelin
2018-11-12 13:12 ` Jeff King
2018-11-13 1:52 ` Junio C Hamano
2018-11-20 9:17 ` Оля Тележная
2018-11-21 0:27 ` Junio C Hamano
2018-11-22 11:33 ` Johannes Schindelin
2018-11-24 1:48 ` Junio C Hamano
2018-11-12 13:05 ` Jeff King
2018-12-24 13:16 ` [PATCH v2 0/5] ref-filter: add new formatting options Оля Тележная
2018-12-24 13:24 ` [PATCH v2 1/6] ref-filter: add objectsize:disk option Olga Telezhnaya
2018-12-24 13:24 ` [PATCH v2 3/6] ref-filter: add tests for objectsize:disk Olga Telezhnaya
2018-12-24 13:24 ` [PATCH v2 2/6] ref-filter: add check for negative file size Olga Telezhnaya
2018-12-24 13:24 ` [PATCH v2 4/6] ref-filter: add deltabase option Olga Telezhnaya
2018-12-24 13:24 ` [PATCH v2 6/6] ref-filter: add docs for new options Olga Telezhnaya
2018-12-24 13:24 ` [PATCH v2 5/6] ref-filter: add tests for deltabase Olga Telezhnaya
2018-12-26 20:44 ` Junio C Hamano [this message]
2019-01-10 6:25 ` [PATCH v2 0/5] ref-filter: add new formatting options Оля Тележная
2019-01-10 6:32 ` [PATCH v3 1/6] ref-filter: add objectsize:disk option Olga Telezhnaya
2019-01-10 6:32 ` [PATCH v3 5/6] ref-filter: add tests for deltabase Olga Telezhnaya
2019-01-10 6:32 ` [PATCH v3 2/6] ref-filter: add check for negative file size Olga Telezhnaya
2019-01-10 6:32 ` [PATCH v3 3/6] ref-filter: add tests for objectsize:disk Olga Telezhnaya
2019-01-10 6:32 ` [PATCH v3 4/6] ref-filter: add deltabase option Olga Telezhnaya
2019-01-10 6:32 ` [PATCH v3 6/6] ref-filter: add docs for new options Olga Telezhnaya
2019-01-10 18:17 ` [PATCH v2 0/5] ref-filter: add new formatting options Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwontmmuv.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=olyatelezhnaya@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).