From: Junio C Hamano <gitster@pobox.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Johannes Sixt <j6t@kdbg.org>,
Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org,
Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH v2 0/2] Brown-bag fix on top of js/mingw-inherit-only-std-handles
Date: Sat, 30 Nov 2019 12:23:20 -0800 [thread overview]
Message-ID: <xmqqwobh15c7.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <8736e5t98b.fsf@igel.home> (Andreas Schwab's message of "Sat, 30 Nov 2019 21:11:48 +0100")
Andreas Schwab <schwab@linux-m68k.org> writes:
> On Nov 30 2019, Johannes Sixt wrote:
>
>> Am 30.11.19 um 19:04 schrieb Junio C Hamano:
>>> "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
>>> writes:
>>>
>>>> * We now assign errno only when the call to CreateProcessW() failed.
>>>
>>> Meaning the global variable 'errno' is left as it was (instead of
>>> getting cleared) when a system call succeeds? That I think is the
>>> correct behaviour people who use the variable expect.
>>
>> I hope you mean people who read the code. You cannot possibly mean
>> developers who expect that the run-command API keeps errno unchanged if
>> the calls were successful. I'm pretty sure they do not provide such a
>> guarantee.
>
> POSIX guarantees that no library function sets errno to zero.
It is true, but the rest of the Git code works on top of an
abstraction a bit higher than C/POSIX library. The run-command API
J6t cites is an example.
IOW, we cannot take advantage of that POSIX guarantee in the
codepaths that use our internal API. So...
next prev parent reply other threads:[~2019-11-30 20:24 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-29 21:44 [PATCH 0/1] Brown-bag fix on top of js/mingw-inherit-only-std-handles Johannes Schindelin via GitGitGadget
2019-11-29 21:44 ` [PATCH 1/1] mingw: do set `errno` correctly when trying to restrict handle inheritance Johannes Schindelin via GitGitGadget
2019-11-29 23:02 ` Johannes Sixt
2019-11-30 22:06 ` Johannes Schindelin
2019-11-30 22:16 ` Johannes Sixt
2019-11-30 10:36 ` [PATCH v2 0/2] Brown-bag fix on top of js/mingw-inherit-only-std-handles Johannes Schindelin via GitGitGadget
2019-11-30 10:36 ` [PATCH v2 1/2] mingw: do set `errno` correctly when trying to restrict handle inheritance Johannes Schindelin via GitGitGadget
2019-11-30 10:36 ` [PATCH v2 2/2] mingw: translate ERROR_SUCCESS to errno = 0 Johannes Schindelin via GitGitGadget
2019-11-30 18:04 ` [PATCH v2 0/2] Brown-bag fix on top of js/mingw-inherit-only-std-handles Junio C Hamano
2019-11-30 19:13 ` Johannes Sixt
2019-11-30 20:11 ` Andreas Schwab
2019-11-30 20:23 ` Junio C Hamano [this message]
2019-11-30 20:43 ` Andreas Schwab
2019-11-30 21:22 ` Johannes Schindelin
2019-11-30 20:21 ` Junio C Hamano
2019-12-01 6:26 ` Junio C Hamano
2019-12-01 9:53 ` Johannes Schindelin
2019-12-02 6:07 ` Junio C Hamano
2019-12-02 9:05 ` Johannes Schindelin
2019-11-30 19:20 ` Johannes Sixt
2019-11-30 22:09 ` Junio C Hamano
2019-12-02 11:33 ` [PATCH v3 " Johannes Schindelin via GitGitGadget
2019-12-02 11:33 ` [PATCH v3 1/2] mingw: do set `errno` correctly when trying to restrict handle inheritance Johannes Schindelin via GitGitGadget
2019-12-02 11:33 ` [PATCH v3 2/2] mingw: translate ERROR_SUCCESS to errno = 0 Johannes Schindelin via GitGitGadget
2019-12-02 17:35 ` [PATCH v3 0/2] Brown-bag fix on top of js/mingw-inherit-only-std-handles Johannes Sixt
2019-12-02 19:04 ` Junio C Hamano
2019-12-03 12:04 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwobh15c7.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=j6t@kdbg.org \
--cc=johannes.schindelin@gmx.de \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).