From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id E306D1F466 for ; Fri, 31 Jan 2020 18:40:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726163AbgAaSkH (ORCPT ); Fri, 31 Jan 2020 13:40:07 -0500 Received: from pb-smtp20.pobox.com ([173.228.157.52]:56795 "EHLO pb-smtp20.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725909AbgAaSkH (ORCPT ); Fri, 31 Jan 2020 13:40:07 -0500 Received: from pb-smtp20.pobox.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 80417ABE1A; Fri, 31 Jan 2020 13:40:05 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=lYvsooNyR3nIH22LkpH6y+10sLM=; b=XnFvWU oI8ExtFAMt7k+iYy62Cdup89BBXmuDQVNSP3msyNU2JdEOHiOm1P9DSaC5YcUmXc fmr8vBmPu5zp+t5MJy8KmNRrlgDrpIJfUjXxbtI4FdEVqEINsyAIcYS6/Wl9+Nx2 Tq6lMMZ/N4amAmtM6ibnfWXaQwqmmH4DioJnU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=fs1vO09MzOpkCcAudOtSojf4VvmmMbVm 1QhWi0zt2bwvT/udyw+nRXUawKp7rHVZB+XfwTpjZjZA6guNV/hZfj3GN7s4FMXZ iHjIeqSAQCRULszerGKmRdZuGZGQ1uCBGUalX7GpdoHBVfFv+nxeKklae9EgT05s TbK+0FsI3B4= Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 77FFBABE19; Fri, 31 Jan 2020 13:40:05 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.76.80.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp20.pobox.com (Postfix) with ESMTPSA id 8C39EABE16; Fri, 31 Jan 2020 13:40:02 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: Miriam Rubio Cc: git@vger.kernel.org, Pranit Bauva , Christian Couder , Tanushree Tumane Subject: Re: [PATCH v2 08/11] bisect: libify `check_merge_bases` and its dependents References: <20200128144026.53128-1-mirucam@gmail.com> <20200128144026.53128-9-mirucam@gmail.com> Date: Fri, 31 Jan 2020 10:40:00 -0800 In-Reply-To: <20200128144026.53128-9-mirucam@gmail.com> (Miriam Rubio's message of "Tue, 28 Jan 2020 15:40:23 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 1789C772-4459-11EA-8D76-B0405B776F7B-77302942!pb-smtp20.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Miriam Rubio writes: > + * - If a merge base must be tested, on success return -11 a special condition Is this eleven something the original (scripted version) used, or what this series invented? If the latter, what was the reason the value was chosen, and what were the constraints when choosing the value (e.g. it cannot be used an exit code by something)? In any case, these values (if there other special codes defined) should be given symbolic names (either #define or enum).