From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 6168A1F619 for ; Thu, 19 Mar 2020 22:02:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727374AbgCSWCm (ORCPT ); Thu, 19 Mar 2020 18:02:42 -0400 Received: from pb-smtp21.pobox.com ([173.228.157.53]:54290 "EHLO pb-smtp21.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727302AbgCSWCl (ORCPT ); Thu, 19 Mar 2020 18:02:41 -0400 Received: from pb-smtp21.pobox.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 9C738A9BEA; Thu, 19 Mar 2020 18:02:41 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=6A2DpfRm4ygh AAzIQbmHwYeLzDI=; b=yMteexmoEvTUWaRUntfuh8rUzzXvZ7NS3X8Ejy125iTJ QN5+a2ZpXtuG/aEjf5gKw19o+92sxu2cSGhcrPcVafFtgx1xkkNiZXlLzzhyh/4o eJPjQpXE1xLmSmJe7cZgjI4hmITXvbSOa+53iAyP79YWfkIpvYAd6pu4JYQeynk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; q=dns; s=sasl; b=cf1/6A dHY5vq0R6wnmrrQYfvOTO5Ca3IqQiH7bySCSkUy1/rfB+eyPaqtYM6/IRyKMLMUV BPcZJI7WZYMK88DaSS8wdpOtczqofvXa9K5rcV3FZbIiiZ/CV64BJQloeNKR3pFe oEnEOCoHBijhocQ1kB55N8PIRFPrM3gxq+nn4= Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 93B4BA9BE9; Thu, 19 Mar 2020 18:02:41 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.74.119.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp21.pobox.com (Postfix) with ESMTPSA id DC2D2A9BE2; Thu, 19 Mar 2020 18:02:38 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: Eric Sunshine Cc: Jeff King , =?utf-8?B?xJBvw6BuIFRy4bqnbiBDw7RuZw==?= Danh , Git List Subject: Re: [PATCH 1/6] t4061: use POSIX compliance regex(7) References: <20200319155307.GB3513282@coredump.intra.peff.net> Date: Thu, 19 Mar 2020 15:02:37 -0700 In-Reply-To: (Eric Sunshine's message of "Thu, 19 Mar 2020 12:01:28 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Pobox-Relay-ID: 591A7598-6A2D-11EA-8E6B-8D86F504CC47-77302942!pb-smtp21.pobox.com Content-Transfer-Encoding: quoted-printable Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Eric Sunshine writes: > On Thu, Mar 19, 2020 at 11:53 AM Jeff King wrote: >> On Thu, Mar 19, 2020 at 09:00:02PM +0700, =C4=90o=C3=A0n Tr=E1=BA=A7n = C=C3=B4ng Danh wrote: >> > Fix it by using literal `+` instead. >> >> This makes sense, I think. It could hurt a sed which is expected ERE a= nd >> needs the "+" escaped, but I think such a sed would be wrong (and I >> imagine would break things elsewhere). > > I had the same thought and considered suggesting a character class: > > sed -n -e "1,4d" -e "s/^[+]//p" <"$1" >.tmp-1 > > to make it painfully obvious that "+" is not special in the > expression. But then I thought better of it -- for the same reason as > you (to wit: such a 'sed' would be wrong) -- and decided against > saying anything. I have only one thing that needs fixing, which is s/compliance/compliant/= ; on the title. Other than that, it looks good. Having said that, I would have done the [+] thing if I were doing this patch myself. As long as we see no "wrong" sed that is broken by this change, I am OK with it, though. Thanks.