From: Junio C Hamano <gitster@pobox.com>
To: Parth Gala <parthpgala@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>, chriscool@tuxfamily.org
Subject: Re: [GSoC Project RFC] "git log --oneline" improvements
Date: Fri, 20 Mar 2020 16:36:40 -0700 [thread overview]
Message-ID: <xmqqwo7ea99z.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <28aee28c-8e8d-763a-66c7-d365025e56a2@gmail.com> (Parth Gala's message of "Sat, 21 Mar 2020 04:41:34 +0530")
Parth Gala <parthpgala@gmail.com> writes:
> I went through the discussions here[1] and here[2] and what I could
> conclude from [1] is, the 'git log --oneline' command currently shows the
> decorations of a commit before the commit message but after the shortened
> hash due to which the alignment of the messages is disturbed like this,
>
> 3f07dac29 (HEAD -> master) pathspec: don't error out on all-excl...
> ca4a562f2 pathspec magic: add '^' as alias for '!'
> 02555c1b2 ls-remote: add "--diff" option to show only refs that differ
> 6e3a7b339 (tag: v2.12.0-rc0, origin/master, origin/HEAD) Git 2.12-rc0
> fafca0f72 Merge branch 'cw/log-updates-for-all-refs-really'
> 74dee5cfa Merge branch 'pl/complete-diff-submodule-diff'
> 36acf4123 Merge branch 'rs/object-id'
>
> And if the decorations were to be shown after the message and you were
> checking the logs just to see the status of a branch rather than the
> contents then you would again be at a disadvantage, since you would want
> to have them visible right next to the hashes. Besides decorations at the
> end would have the inconvenience of being truncated at the end of the line
> on smaller screens.
>
> This format for --oneline with decorations was decided upon,
>
> b9df16a4c (HEAD -> master)
> pathspec: don't error out on all-exclusionary pathspec patterns
> 91a491f05 pathspec magic: add '^' as alias for '!'
> c8e05fd6d ls-remote: add "--diff" option to show only refs that differ
> 20769079d (tag: v2.12.0-rc2, origin/master, origin/HEAD)
> Git 2.12-rc2
> 076c05393 Hopefully the final batch of mini-topics before the final
Hmph. Who decided that such a format is a good idea? I do not see
anything decided positively in the thread [1] you referred to.
> In [2] such formats with date and timestamp are discussed along with
> compatibility for --graph option as well,
>
> === 2015-09-17 ===
> * ee6ad5f4 12:16 jch (tag: v2.5.3) Git 2.5.3
> === 2015-09-09 ===
> * b9d66899 14:22 js am --skip/--abort: merge HEAD/ORIG_HEAD tree
> into index
> | === 2015-09-04 ===
> | * 27ea6f85 10:46 jch (tag: v2.5.2) Git 2.5.2
> * 74b67638 10:36 jch (tag: v2.4.9) Git 2.4.9
> ..........
> * ecad27cf 10:32 jch (tag: v2.3.9) Git 2.3.9
>
> So these are the two main formats to be enhanced along with as many options
> of log as possible. What are your views on this ?
>
Making the "--oneline" format to consume more than one line for a
commit is probably not what we want anyway.
Coming up with a new format (say, "--pretty=concise"), or a new
option that tweaks the behaviour of "--oneline", are possible ways
to add a new feature without disrupting existing users' use cases,
though.
Thanks.
next prev parent reply other threads:[~2020-03-20 23:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 23:11 [GSoC Project RFC] "git log --oneline" improvements Parth Gala
2020-03-20 23:36 ` Junio C Hamano [this message]
2020-03-21 22:05 ` Parth Gala
2020-03-21 22:37 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwo7ea99z.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=parthpgala@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).