From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>,
git@vger.kernel.org, hanwen@google.com
Subject: Re: [PATCH] reftable: technical documentation link fixes
Date: Wed, 27 May 2020 10:14:35 -0700 [thread overview]
Message-ID: <xmqqwo4xl2pw.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200527022142.GB172669@google.com> (Jonathan Nieder's message of "Tue, 26 May 2020 19:21:42 -0700")
Jonathan Nieder <jrnieder@gmail.com> writes:
> Carlo Marcelo Arenas Belón wrote:
>
>> Subject: reftable: technical documentation link fixes
>
> For next time, try to make the subject line summarize what specific
> improvement the patch makes. For example:
>
> reftable doc: use link: and urlencode to avoid dead links
>
>> Showing as broken links in the html version (when using asciidoc 8.6.10)
>> because some of the characters in the url need encoding.
>>
>> Change them to use a explicit "link" and URL encode the problematic
>> charecters (ex: +, =, @). While at it, change the base URL to use
>> lore.kernel.org as has been suggested since 56e6c16394 (Merge branch
>> 'dl/lore-is-the-archive', 2019-12-06)
>>
>> Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
>> ---
>> Documentation/technical/reftable.txt | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Will queue at the tip of hn/reftable for now, but post 2.27-final,
we should tentatively eject hn/refs-cleanup out of 'next' and squash
this fix in to the step that originally introduced the problem (and
of course, new version of hn/reftable need to be based on the updated
hn/refs-cleanup topic when it happens).
Thanks, both.
prev parent reply other threads:[~2020-05-27 17:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-25 21:02 [PATCH] reftable: technical documentation link fixes Carlo Marcelo Arenas Belón
2020-05-25 22:00 ` Carlo Marcelo Arenas Belón
2020-05-26 18:53 ` Han-Wen Nienhuys
2020-05-26 23:16 ` Carlo Marcelo Arenas Belón
2020-05-27 2:21 ` Jonathan Nieder
2020-05-27 17:14 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwo4xl2pw.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=hanwen@google.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).