From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: trygveaa@gmail.com, git@vger.kernel.org,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Jeff Hostetler <jeffhost@microsoft.com>,
Heba Waly <heba.waly@gmail.com>
Subject: Re: [PATCH 1/2] Wait for child on signal death for aliases to builtins
Date: Mon, 06 Jul 2020 18:50:05 -0700 [thread overview]
Message-ID: <xmqqwo3g6qlu.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200706204106.GA85133@coredump.intra.peff.net> (Jeff King's message of "Mon, 6 Jul 2020 16:41:06 -0400")
Jeff King <peff@peff.net> writes:
> On Sun, Jul 05, 2020 at 12:18:37AM +0200, trygveaa@gmail.com wrote:
>
>> From: Trygve Aaberge <trygveaa@gmail.com>
>>
>> When you hit ^C all the processes in the tree receives it. When a git
>> command uses a pager, git ignores this and waits until the pager quits.
>> However, when using an alias there is an additional process in the tree
>> which didn't ignore the signal. That caused it to exit which in turn
>> caused the pager to exit. This fixes that for aliases to builtins.
>>
>> This was originally fixed in 46df6906f3 (see that for a more in
>> explanation), but broke by a regression in b914084007.
>
> Good catch. The regression is technically in b914084007, but the real
> culprit is the extra (commented out) code path added in ee4512ed48
> (trace2: create new combined trace facility, 2019-02-22).
True, as Dscho also mentioned. I'll just do "b914084007" =>
"ee4512ed48 and b914084007" while queueing.
> Your fix here looks good, but it does make me wonder if we could avoid
> or shrink this duplicate code path. I.e., could it just do the logging
> necessary but still leave the actual process spawn to the
> execv_dashed_external() below. It may be hard to untangle, though, so
> certainly this makes sense in the meantime.
It probably is a bit more involved than a typical low hanging
fruit. I am OK to leave this for later clean-up.
> A test would be nice, but I don't think it's very feasible for the same
> reason mentioned in 46df6906f3.
True. Thanks.
next prev parent reply other threads:[~2020-07-07 1:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-04 22:18 [PATCH 1/2] Wait for child on signal death for aliases to builtins trygveaa
2020-07-04 22:18 ` [PATCH 2/2] Wait for child on signal death for aliases to externals trygveaa
2020-07-06 21:14 ` Jeff King
2020-07-07 1:38 ` Junio C Hamano
2020-07-07 10:19 ` Trygve Aaberge
2020-07-07 22:06 ` Jeff King
2020-07-05 2:15 ` [PATCH 1/2] Wait for child on signal death for aliases to builtins Johannes Schindelin
2020-07-07 1:48 ` Junio C Hamano
2020-07-06 20:41 ` Jeff King
2020-07-07 1:50 ` Junio C Hamano [this message]
2020-07-07 10:23 ` Trygve Aaberge
2020-07-07 12:17 ` [PATCH v2 " trygveaa
2020-07-07 12:17 ` [PATCH v2 2/2] Wait for child on signal death for aliases to externals trygveaa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwo3g6qlu.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=heba.waly@gmail.com \
--cc=jeffhost@microsoft.com \
--cc=peff@peff.net \
--cc=trygveaa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).