From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id D26A11F4B4 for ; Wed, 16 Sep 2020 22:13:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726506AbgIPWNy (ORCPT ); Wed, 16 Sep 2020 18:13:54 -0400 Received: from pb-smtp20.pobox.com ([173.228.157.52]:61459 "EHLO pb-smtp20.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726269AbgIPWNv (ORCPT ); Wed, 16 Sep 2020 18:13:51 -0400 Received: from pb-smtp20.pobox.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 94CBAE8D37; Wed, 16 Sep 2020 17:15:04 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=6TLXN/dtjDlr tF1Ae7zQvXyp/C8=; b=x/es+bPxE+oFoxlJ4PyW6+z9pw4l3a0f/Ycc8XijAEld sqYKRozV9biNgEa/c8QdVXaUDcWC902WCktgqrd6JQu+TgZSBy3Ico3av6SEJegw 3/M/xpgPsDBZTA9DyWxB8K/boINzaBDFWhLB41C7jc4x/nrfSSqPmu8vOS2lfi4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; q=dns; s=sasl; b=uSa3fp rz+t+JJBEan7ru+wKNXgSkzBFYBvg3J9RDpHt7k8BvP7MCBhOLY54Ve5sI14PUqh w697OacELrakss91R7xmfOp12ZKfXN7wfofN4GdHFDFQMRJQ8RCP1BIS9MgrWRs3 VYZf5VzkIBNfbp+REeE/FqpNE0oMGkn06Guyw= Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 8B421E8D36; Wed, 16 Sep 2020 17:15:04 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.75.7.245]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp20.pobox.com (Postfix) with ESMTPSA id BB6FAE8D34; Wed, 16 Sep 2020 17:15:01 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: git@vger.kernel.org, Matthieu Moy , Johannes Schindelin , Antoine =?utf-8?Q?Beaupr=C3=A9?= , Simon Legner Subject: Re: [PATCH 09/15] remote-mediawiki tests: use "$dir/" instead of "$dir." References: <20200916102918.29805-1-avarab@gmail.com> <20200916102918.29805-10-avarab@gmail.com> Date: Wed, 16 Sep 2020 14:15:00 -0700 In-Reply-To: <20200916102918.29805-10-avarab@gmail.com> (=?utf-8?B?IsOG?= =?utf-8?B?dmFyIEFybmZqw7Zyw7A=?= Bjarmason"'s message of "Wed, 16 Sep 2020 12:29:12 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Pobox-Relay-ID: AEE29880-F861-11EA-B195-F0EA2EB3C613-77302942!pb-smtp20.pobox.com Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason writes: > Change UI messages to use "$dir/" instead of "$dir.". I think this is > less confusing. > > Signed-off-by: =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason > --- > contrib/mw-to-git/t/test-gitmw-lib.sh | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/contrib/mw-to-git/t/test-gitmw-lib.sh b/contrib/mw-to-git/= t/test-gitmw-lib.sh > index a466be8f3f..aa04ebfd0f 100755 > --- a/contrib/mw-to-git/t/test-gitmw-lib.sh > +++ b/contrib/mw-to-git/t/test-gitmw-lib.sh > @@ -343,10 +343,10 @@ wiki_install () { > "http://download.wikimedia.org/mediawiki/$MW_VERSION_MAJOR/"\ > "$MW_FILENAME. "\ > "Please fix your connection and launch the script again." > - echo "$MW_FILENAME downloaded in $(pwd). "\ > + echo "$MW_FILENAME downloaded in $(pwd)/ "\ > "You can delete it later if you want." "$(pwd)/." to keep the full-stop of the first sentence? > else > - echo "Reusing existing $MW_FILENAME downloaded in $(pwd)." > + echo "Reusing existing $MW_FILENAME downloaded in $(pwd)/" > fi > archive_abs_path=3D$(pwd)/$MW_FILENAME > cd "$WIKI_DIR_INST/$WIKI_DIR_NAME/" ||