From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <git-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS shortcircuit=no
	autolearn=ham autolearn_force=no version=3.4.2
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by dcvr.yhbt.net (Postfix) with ESMTP id 3AA401F4B4
	for <e@yhbt.net>; Thu, 24 Sep 2020 18:38:24 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728700AbgIXSiT (ORCPT <rfc822;e@yhbt.net>);
        Thu, 24 Sep 2020 14:38:19 -0400
Received: from pb-smtp20.pobox.com ([173.228.157.52]:53951 "EHLO
        pb-smtp20.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1728264AbgIXSiT (ORCPT <rfc822;git@vger.kernel.org>);
        Thu, 24 Sep 2020 14:38:19 -0400
Received: from pb-smtp20.pobox.com (unknown [127.0.0.1])
        by pb-smtp20.pobox.com (Postfix) with ESMTP id 9C82FE2520;
        Thu, 24 Sep 2020 14:38:17 -0400 (EDT)
        (envelope-from junio@pobox.com)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc
        :subject:references:date:in-reply-to:message-id:mime-version
        :content-type; s=sasl; bh=98WpGpz4J78xKZJwQ1rBVST4KEg=; b=Nhcnaz
        n+Rmo2LHALm5kg244XQyqAY/DMS8bcYN2p4AGok+TvAV+WAtEhFPHHPSUgxkRQuH
        t4ubmpIe/qBIrcWHHysgLRmMkRyRKPX0WNWiJBz+XOmPuvWbKLSFkwY+oIxN7iuy
        8nXBD1UgzQVR34jzLcYMZH3/EiXrId2eoFrbs=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc
        :subject:references:date:in-reply-to:message-id:mime-version
        :content-type; q=dns; s=sasl; b=M39C6+573UiwbEdl4hqA+sDUer8ybklX
        7tC8S9K9PiOjPumH6AV+UnReX9JZP+XRghHZZkEbIx1JsuizEqlxhMXjzqnz24He
        hL04h73slQygGJjf+2L+6hQxEjBcTtXktDq3lCrGozYaQL0T/exbJqOGIdKHf+Hu
        4DDZ+FyhxX8=
Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1])
        by pb-smtp20.pobox.com (Postfix) with ESMTP id 94BF4E251D;
        Thu, 24 Sep 2020 14:38:17 -0400 (EDT)
        (envelope-from junio@pobox.com)
Received: from pobox.com (unknown [34.74.119.39])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by pb-smtp20.pobox.com (Postfix) with ESMTPSA id D73B0E251B;
        Thu, 24 Sep 2020 14:38:14 -0400 (EDT)
        (envelope-from junio@pobox.com)
From:   Junio C Hamano <gitster@pobox.com>
To:     Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc:     Christian Couder <christian.couder@gmail.com>,
        git <git@vger.kernel.org>,
        Christian Couder <chriscool@tuxfamily.org>,
        Miriam Rubio <mirucam@gmail.com>
Subject: Re: [PATCH] bisect: don't use invalid oid as rev when starting
References: <20200923170915.21748-1-chriscool@tuxfamily.org>
        <nycvar.QRO.7.76.6.2009232229000.5061@tvgsbejvaqbjf.bet>
        <nycvar.QRO.7.76.6.2009232302050.5061@tvgsbejvaqbjf.bet>
        <xmqqa6xgi363.fsf@gitster.c.googlers.com>
        <CAP8UFD3mfPgedqGk0ZFp3K3r1gDA3-stbSxoEomRh4T0_qH+tg@mail.gmail.com>
        <nycvar.QRO.7.76.6.2009240950010.5061@tvgsbejvaqbjf.bet>
        <xmqqo8lvgmdw.fsf@gitster.c.googlers.com>
Date:   Thu, 24 Sep 2020 11:38:13 -0700
In-Reply-To: <xmqqo8lvgmdw.fsf@gitster.c.googlers.com> (Junio C. Hamano's
        message of "Thu, 24 Sep 2020 09:39:07 -0700")
Message-ID: <xmqqwo0jm356.fsf@gitster.c.googlers.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Pobox-Relay-ID: 1B3F6ED4-FE95-11EA-99B7-F0EA2EB3C613-77302942!pb-smtp20.pobox.com
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org

Junio C Hamano <gitster@pobox.com> writes:

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
>>> Hopefully the V2 I just sent will be better anyway.
>>
>> FWIW I was working off of Miriam's `git-bisect-work-part2-v8` branch at
>> https://gitlab.com/mirucam/git.git.
>>
>> I'm happy with Christian's v2 (with or without the indentation fixes I
>> suggested).
>
> Thanks, both of you.  The updated one does look good.

Oops, do you mean s/path restriction/pathspec/ fix?  v2 looks OK nesting-wise
and I think your indentex-fix suggestion was for the previous one.

Just making sure...

Thanks.