From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 54DED1F66F for ; Tue, 3 Nov 2020 01:35:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727138AbgKCBfq (ORCPT ); Mon, 2 Nov 2020 20:35:46 -0500 Received: from pb-smtp1.pobox.com ([64.147.108.70]:58442 "EHLO pb-smtp1.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726817AbgKCBfq (ORCPT ); Mon, 2 Nov 2020 20:35:46 -0500 Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id CE3ADA3394; Mon, 2 Nov 2020 20:35:43 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:message-id:mime-version:content-type; s=sasl; bh=IrXAOjJTkJjEaeKt5fU031oTSXI=; b=R/vJyeZi75YHK5QKWNJQ W7oi1Qn/9YJ3btLFGItmD08OSGCpmPWKTuWe7DgikdK2ItWBIy0fSAjfUmjcmyP1 5n7ytrSuKWw32ltraz/KNepfLh7a/f52+M6c0W+xkCQpr+35XAg+n0eVnqNmOhmG Tync9ZxpG2JMwwgU2Q4r8Z4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:message-id:mime-version:content-type; q=dns; s=sasl; b=s1O3xYZTIWMvC0V64HRwLHyLLJf21cIKJ0YZidz1FbcCbP DIaD4UBS0mh64bwSCCdkBssMSuUVpq3sV4Ag1SIgkqe/9/UZioPL+ztznYe8WYR6 Phsp+g6R5Ghm1khcFyt6TllbCU2gHQkoN84eL7Xc4LUtGxt0Ks7UCHKhmvLq0= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id C2D30A3393; Mon, 2 Nov 2020 20:35:43 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.75.7.245]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 4D115A3392; Mon, 2 Nov 2020 20:35:43 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: Aaron Schrab Cc: Felipe Contreras , Stefan Haller , Git , SZEDER =?utf-8?Q?G?= =?utf-8?Q?=C3=A1bor?= , =?utf-8?B?Tmd1eeG7hW4gVGjDoWkgTmfhu41j?= Duy Subject: Re: [PATCH 00/14] completion: a bunch of updates References: <0ec43318-bf83-25c4-a817-a150e2e47546@haller-berlin.de> <010c6222-4365-7446-a666-333ac7b4d415@haller-berlin.de> Date: Mon, 02 Nov 2020 17:35:42 -0800 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: E3640E08-1D74-11EB-A09B-D152C8D8090B-77302942!pb-smtp1.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Aaron Schrab writes: > At 14:29 -0600 02 Nov 2020, Felipe Contreras wrote: >>So the two options are: >> >>1. Use the script in contrib/ (or git-completion) >>2. Use Oh-My-Zsh and enable the "gitfast" plugin >> >>In my opinion to use the Zsh default completion is not an option. >> >>Which is why I think distributions should package the Git Zsh >>completion by default (like Hombrew does), which will happen more >>easily if Git graduated those scripts and installed them by default. > > The option that you consider to be invalid is definitely *my* > preferred option. That Homebrew's git package installs the completion > in a way that overrides that from the zsh package was a source of > continual annoyance for me until I put in a long-term workaround for > that (I had just been removing the symlink every time I noticed that > it had been created by a new install of the git package). Thanks for a data point. My understanding is that Felipe's 1 & 2 are essentially the same thing in the larger picture but they come in different packaging. If we talk about two choices, I think they are between the Zsh default or gitfast from oh-my-zsh. And your preference is the former. It is not like I picked a wrong SO thread and was swayed by an oddball opinion of somebody who prefers the Zsh default. Even though the preference is up to individual users, the important point here is that Zsh default is not universally unusable for everybody and it is one of the valid choices.