From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Orgad Shaneh via GitGitGadget <gitgitgadget@gmail.com>,
Git List <git@vger.kernel.org>, Orgad Shaneh <orgads@gmail.com>
Subject: Re: [PATCH v4 1/2] hooks: allow input from stdin for commit-related hooks
Date: Thu, 19 Nov 2020 13:32:09 -0800 [thread overview]
Message-ID: <xmqqwnyhvxra.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <CAPig+cSN=-7KWgDcXM8po44PEKi27U6mJEEL0mj_wrTJBUf=WA@mail.gmail.com> (Eric Sunshine's message of "Thu, 19 Nov 2020 16:23:11 -0500")
Eric Sunshine <sunshine@sunshineco.com> writes:
> Rather than making such a fundamental change and having to deal with
> the fallout by introducing complexity to handle various special-cases
> which pop up now and in the future, I wonder if it makes more sense to
> instead just update documentation to tell hook authors to read
> explicitly from the console rather than expecting stdin to be
> available (since stdin may already be consumed for other purposes when
> dealing with hooks or commands which invoke the hooks).
;-)
Thanks for saying this.
next prev parent reply other threads:[~2020-11-19 21:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-17 15:02 [PATCH] hooks: allow input from stdin Orgad Shaneh via GitGitGadget
2020-11-17 19:59 ` Junio C Hamano
2020-11-19 15:50 ` [PATCH v2] " Orgad Shaneh via GitGitGadget
2020-11-19 15:56 ` [PATCH v3] hooks: allow input from stdin for commit-related hooks Orgad Shaneh via GitGitGadget
2020-11-19 19:16 ` Junio C Hamano
2020-11-19 20:41 ` Orgad Shaneh
2020-11-19 20:56 ` [PATCH v4 0/2] " Orgad Shaneh via GitGitGadget
2020-11-19 20:56 ` [PATCH v4 1/2] " Orgad Shaneh via GitGitGadget
2020-11-19 21:23 ` Eric Sunshine
2020-11-19 21:32 ` Junio C Hamano [this message]
2020-11-20 5:23 ` Orgad Shaneh
2020-11-20 6:38 ` Eric Sunshine
2020-11-20 6:48 ` Eric Sunshine
2020-11-20 7:16 ` Orgad Shaneh
2020-11-20 18:13 ` Junio C Hamano
2020-11-20 10:59 ` Ævar Arnfjörð Bjarmason
2020-11-20 12:34 ` Orgad Shaneh
2020-11-19 20:56 ` [PATCH v4 2/2] commit: fix stdin conflict between message and hook Orgad Shaneh via GitGitGadget
2020-12-09 20:06 ` [PATCH v5 0/2] hooks: allow input from stdin for commit-related hooks Orgad Shaneh via GitGitGadget
2020-12-09 20:06 ` [PATCH v5 1/2] hooks: lay foundations for passing stdin to hooks Orgad Shaneh via GitGitGadget
2020-12-09 20:06 ` [PATCH v5 2/2] hooks: allow input from stdin for commit-related hooks Orgad Shaneh via GitGitGadget
2020-12-09 22:37 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwnyhvxra.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=orgads@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).