git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Derrick Stolee <stolee@gmail.com>
Cc: git@vger.kernel.org, Elijah Newren <newren@gmail.com>
Subject: Re: What's cooking in git.git (Apr 2021, #01; Mon, 5)
Date: Tue, 06 Apr 2021 14:35:29 -0700	[thread overview]
Message-ID: <xmqqwntf14gu.fsf@gitster.g> (raw)
In-Reply-To: <6000ac2f-5d6d-09a2-c44d-4090e3d4c804@gmail.com> (Derrick Stolee's message of "Tue, 6 Apr 2021 08:57:22 -0400")

Derrick Stolee <stolee@gmail.com> writes:

> On 4/5/2021 9:08 PM, Junio C Hamano wrote:> * ds/clarify-hashwrite (2021-03-26) 1 commit
>>   (merged to 'next' on 2021-03-30 at 701f5c0696)
>>  + csum-file: make hashwrite() more readable
>> 
>>  The hashwrite() API always resulted in a call to write(2), even
>>  when writing a small amount of bytes that would still fit in the
>>  internal buffer held by the hashfile struct.  It has been updated
>>  to delay the writing until the buffer is filled or the hashfile
>>  concluded for performance.
>
> Sorry for not noticing earlier, but this branch description is
> based on my erroneous understanding of the change in v1. The
> commit now only rearranges and comments the method to be more
> clear that it is correctly buffering the data. Perhaps this
> could be a substitute?
>
>   The hashwrite() API uses a buffering mechanism to avoid calling
>   write(2) too frequently. This logic has been refactored to be
>   easier to understand.

Thanks, yes I did recall we replaced this topic with an updated
version that concentrates on readability.  The proposed text looks
good.

>> * ds/sparse-index (2021-03-30) 21 commits
>> ...
>>  (this branch is used by ds/sparse-index-protections.)
>> 
>>  Both in-core and on-disk index has been updated to optionally omit
>>  individual entries and replace them with the tree object that
>>  corresponds to the directory that contains them when the "cone"
>>  mode of sparse checkout is in use.
>
> I believe this one has been stable for a little while. Do you
> think it could be a candidate for 'next' soon? Alternatively,
> you could wait and merge ds/sparse-index and
> ds/sparse-index-protections at the same time. I just know that
> the second series is causing some merge contention with other
> topics.

I was planning to give this another scan before marking it as "Merge
to 'next'", hopefully before the end of this week.

Thanks.

      reply	other threads:[~2021-04-06 21:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-06  1:08 What's cooking in git.git (Apr 2021, #01; Mon, 5) Junio C Hamano
2021-04-06 12:57 ` Derrick Stolee
2021-04-06 21:35   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqwntf14gu.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=newren@gmail.com \
    --cc=stolee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).