From: Junio C Hamano <gitster@pobox.com>
To: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, "Chris. Webster" <chris@webstech.net>,
Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH 2/2] ci(check-whitespace): restrict to the intended commits
Date: Wed, 14 Jul 2021 15:25:15 -0700 [thread overview]
Message-ID: <xmqqwnpsttx0.fsf@gitster.g> (raw)
In-Reply-To: <b63a5bbc63ba17449a91913ab28c268db5fa3650.1626300577.git.gitgitgadget@gmail.com> (Johannes Schindelin via GitGitGadget's message of "Wed, 14 Jul 2021 22:09:37 +0000")
"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
writes:
> Unfortunately, this means that we no longer can rely on a shallow clone:
> There is no way of knowing just how many commits the upstream branch
> advanced after the commit from which the PR branch branched off. So
> let's just go with a full clone instead, and be safe rather than sorry
> (if we have "too shallow" a situation, a commit range `@{u}..` may very
> well include a shallow commit itself, and the output of `git show
> --check <shallow>` is _not_ pretty).
Makes sense.
As long as you have pull-request base, I suspect that you could
shallow clone the base and incrementally fetch the rest to update,
perhaps? But I do not know if it is worth doing so for a small
project like ours.
Thanks.
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---
> .github/workflows/check-whitespace.yml | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/.github/workflows/check-whitespace.yml b/.github/workflows/check-whitespace.yml
> index c53614d6033..8c4358d805c 100644
> --- a/.github/workflows/check-whitespace.yml
> +++ b/.github/workflows/check-whitespace.yml
> @@ -12,15 +12,9 @@ jobs:
> check-whitespace:
> runs-on: ubuntu-latest
> steps:
> - - name: Set commit count
> - shell: bash
> - run: echo "COMMIT_DEPTH=$((1+$COMMITS))" >>$GITHUB_ENV
> - env:
> - COMMITS: ${{ github.event.pull_request.commits }}
> -
> - uses: actions/checkout@v2
> with:
> - fetch-depth: ${{ env.COMMIT_DEPTH }}
> + fetch-depth: 0
>
> - name: git log --check
> id: check_out
> @@ -47,7 +41,7 @@ jobs:
> echo "${dash} ${etc}"
> ;;
> esac
> - done <<< $(git log --check --pretty=format:"---% h% s" -${{github.event.pull_request.commits}})
> + done <<< $(git log --check --pretty=format:"---% h% s" ${{github.event.pull_request.base.sha}}..)
>
> if test -n "${log}"
> then
next prev parent reply other threads:[~2021-07-14 22:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 22:09 [PATCH 0/2] check-whitespace: two fixes Johannes Schindelin via GitGitGadget
2021-07-14 22:09 ` [PATCH 1/2] ci(check-whitespace): stop requiring a read/write token Johannes Schindelin via GitGitGadget
2021-07-14 22:20 ` Junio C Hamano
2021-07-14 22:09 ` [PATCH 2/2] ci(check-whitespace): restrict to the intended commits Johannes Schindelin via GitGitGadget
2021-07-14 22:25 ` Junio C Hamano [this message]
2021-07-14 22:29 ` Taylor Blau
2021-07-15 13:00 ` Johannes Schindelin
2021-07-15 12:59 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwnpsttx0.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=chris@webstech.net \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).