From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Jonathan Nieder <jrnieder@gmail.com>,
Jiang Xin <zhiyou.jx@alibaba-inc.com>
Subject: Re: [PATCH 1/2] bundle tests: use ">file" not ": >file"
Date: Tue, 20 Jul 2021 12:57:34 -0700 [thread overview]
Message-ID: <xmqqwnpkhi6p.fsf@gitster.g> (raw)
In-Reply-To: <patch-1.2-746d727113b-20210720T115052Z-avarab@gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Tue, 20 Jul 2021 13:52:08 +0200")
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> Change redundant uses of ":" on the LHS of a ">" to the more commonly
While the changes are correct, I am not sure if the adjective
"redundant" would apply. The word refers to uses of two or more
when one would suffice, but in this case, you use one explicit no-op
command ":" when you need zero.
> use ">file" pattern.
"use" -> "used".
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---
> t/t5607-clone-bundle.sh | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/t/t5607-clone-bundle.sh b/t/t5607-clone-bundle.sh
> index f4c383cd5ce..c9323a08fe8 100755
> --- a/t/t5607-clone-bundle.sh
> +++ b/t/t5607-clone-bundle.sh
> @@ -54,14 +54,14 @@ test_expect_success 'bundle --stdin <rev-list options>' '
> '
>
> test_expect_success 'empty bundle file is rejected' '
> - : >empty-bundle &&
> + >empty-bundle &&
> test_must_fail git fetch empty-bundle
> '
>
> # This triggers a bug in older versions where the resulting line (with
> # --pretty=oneline) was longer than a 1024-char buffer.
> test_expect_success 'ridiculously long subject in boundary' '
> - : >file4 &&
> + >file4 &&
> test_tick &&
> git add file4 &&
> printf "%01200d\n" 0 | git commit -F - &&
> @@ -75,7 +75,7 @@ test_expect_success 'ridiculously long subject in boundary' '
> '
>
> test_expect_success 'prerequisites with an empty commit message' '
> - : >file1 &&
> + >file1 &&
> git add file1 &&
> test_tick &&
> git commit --allow-empty-message -m "" &&
next prev parent reply other threads:[~2021-07-20 20:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-20 11:52 [PATCH 0/2] bundle tests: modernize, fix missing coverage & test_cmp Ævar Arnfjörð Bjarmason
2021-07-20 11:52 ` [PATCH 1/2] bundle tests: use ">file" not ": >file" Ævar Arnfjörð Bjarmason
2021-07-20 19:57 ` Junio C Hamano [this message]
2021-07-20 20:57 ` Felipe Contreras
2021-07-20 11:52 ` [PATCH 2/2] bundle tests: use test_cmp instead of grep Ævar Arnfjörð Bjarmason
2021-07-20 17:16 ` Taylor Blau
2021-07-21 23:53 ` Ævar Arnfjörð Bjarmason
2021-07-22 18:13 ` Taylor Blau
2021-07-20 17:18 ` [PATCH 0/2] bundle tests: modernize, fix missing coverage & test_cmp Taylor Blau
2021-07-21 23:53 ` [PATCH v2 " Ævar Arnfjörð Bjarmason
2021-07-21 23:53 ` [PATCH v2 1/2] bundle tests: use ">file" not ": >file" Ævar Arnfjörð Bjarmason
2021-07-21 23:53 ` [PATCH v2 2/2] bundle tests: use test_cmp instead of grep Ævar Arnfjörð Bjarmason
2021-07-22 18:17 ` Taylor Blau
2021-07-22 18:17 ` [PATCH v2 0/2] bundle tests: modernize, fix missing coverage & test_cmp Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwnpkhi6p.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=zhiyou.jx@alibaba-inc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).