From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS,URIBL_CSS,URIBL_CSS_A shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id C7CE01F9F4 for ; Tue, 9 Nov 2021 23:10:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237388AbhKIXNM (ORCPT ); Tue, 9 Nov 2021 18:13:12 -0500 Received: from pb-smtp20.pobox.com ([173.228.157.52]:60981 "EHLO pb-smtp20.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232159AbhKIXNL (ORCPT ); Tue, 9 Nov 2021 18:13:11 -0500 Received: from pb-smtp20.pobox.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 059601566DB; Tue, 9 Nov 2021 18:10:25 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=ryGzFjE6rAu0 /8oLdQzU/2XcIQ1x4csbowxxkepmEVQ=; b=xjg1R9/T3jhdQPQEvHdNoL3tYUNZ 9/udUfXnoUB40Ldjma10M2dZOh2RMeIMkn9TP1hB4Iy13KDR+Ux46k8C2DS2glDe 4co8eN/Q3aVJJlZ3htOZ44Kyw9sZRgkncOzzZluH35Jysz/n5L+bpUXSm2n2ZbKO 4iB7NUpu1jOTBnk= Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id F0FF71566DA; Tue, 9 Nov 2021 18:10:24 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [104.133.2.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp20.pobox.com (Postfix) with ESMTPSA id 5BDD91566D8; Tue, 9 Nov 2021 18:10:22 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: git@vger.kernel.org, Phillip Wood , Jeff King , Dan Jacques , Eric Wong , Jonathan Nieder Subject: Re: [PATCH 02/16] Makefile: clean perl/build/ even with NO_PERL=Y References: Date: Tue, 09 Nov 2021 15:10:21 -0800 In-Reply-To: (=?utf-8?B?IsOGdmFyIEFybmZqw7Zyw7A=?= Bjarmason"'s message of "Sat, 6 Nov 2021 22:03:03 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Pobox-Relay-ID: 36F93612-41B2-11EC-AD6D-F327CE9DA9D6-77302942!pb-smtp20.pobox.com Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason writes: > Fix a regression in 499c29394ce (Makefile: allow building without > perl, 2009-04-03) where we'd stop cleaning the perl/* directory > because NO_PERL was defined, thus leaving behind litter if the flag at > "clean" time didn't match that of build time. > > In 499c29394ce this was done to avoid relying on the perl/Makefile.PL, > but since my 20d2a30f8ff (Makefile: replace perl/Makefile.PL with > simple make rules, 2017-12-10) we can clean things in that directory > unconditionally. Nicely analyzed. And it is a nice touch to move the removal next to where we remove the Python stuff. > > Signed-off-by: =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason > --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index 9f57c34e954..82eb8ea446b 100644 > --- a/Makefile > +++ b/Makefile > @@ -3234,6 +3234,7 @@ clean: profile-clean coverage-clean cocciclean > $(RM) $(HCC) > $(RM) -r bin-wrappers $(dep_dirs) $(compdb_dir) compile_commands.json > $(RM) -r po/build/ > + $(RM) -r perl/build/ > $(RM) *.pyc *.pyo */*.pyc */*.pyo $(GENERATED_H) $(ETAGS_TARGET) tags= cscope* > $(RM) -r .dist-tmp-dir .doc-tmp-dir > $(RM) $(GIT_TARNAME).tar.gz > @@ -3242,7 +3243,6 @@ clean: profile-clean coverage-clean cocciclean > $(RM) Documentation/GIT-EXCLUDED-PROGRAMS > ifndef NO_PERL > $(MAKE) -C gitweb clean > - $(RM) -r perl/build/ > endif > $(MAKE) -C templates/ clean > $(MAKE) -C t/ clean