From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 4D2D41F953 for ; Mon, 10 Jan 2022 18:36:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241286AbiAJSgU (ORCPT ); Mon, 10 Jan 2022 13:36:20 -0500 Received: from pb-smtp1.pobox.com ([64.147.108.70]:60206 "EHLO pb-smtp1.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241257AbiAJSe3 (ORCPT ); Mon, 10 Jan 2022 13:34:29 -0500 Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id AFE3E111F43; Mon, 10 Jan 2022 13:34:28 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=pW6t8HSvq4kPSAjV7ZyHUYvXAt/ODOTwP7Vjmy 1Q0bY=; b=H4f/08RQAzsYPTx1h24wkEs5cJCXkx1tm5ZJqF9/fj+MSSOk00UnO5 Q65NTNr68IMyFnOejMnKBSuFarQN96DpAbbjFoxCpBkL9CIrNdMbQvwoqw4KMCPk oxL5ZLPm+jeFo7i2Ubs/6viw6uFgYP7JEV69U/oxbQjpfLrwURz8A= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id A7AF8111F42; Mon, 10 Jan 2022 13:34:28 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [104.133.2.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 0CDA8111F41; Mon, 10 Jan 2022 13:34:27 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: Johannes Schindelin Cc: Teng Long , avarab@gmail.com, congdanhqx@gmail.com, git@vger.kernel.org, peff@peff.net, tenglong.tl@alibaba-inc.com Subject: Re: [PATCH v9 9/9] cocci: allow padding with `strbuf_addf()` References: <8dafb2b3779715aa277eb825a94af87b72f3e093.1641440700.git.dyroneteng@gmail.com> Date: Mon, 10 Jan 2022 10:34:26 -0800 In-Reply-To: (Johannes Schindelin's message of "Fri, 7 Jan 2022 14:03:37 +0100 (CET)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: F170D790-7243-11EC-8201-5E84C8D8090B-77302942!pb-smtp1.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Johannes Schindelin writes: >> The original rule was introduced by commit: >> >> https://github.com/git/git/commit/28c23cd4c3902449aff72cb9a4a703220be0d6ac > > Doing this in 9/9 is too late, by this time you already introduced the > code site that requires this workaround. Good to point this out. Thanks.